Updated Bitmap header #565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the Bitmap header to BITMAPINFOHEADER according to https://en.wikipedia.org/wiki/BMP_file_format#DIB_header_(bitmap_information_header) Slightly improved, now with bitmap size in header. Updating the header was necessary as inserting the previous version inside a PDF document wasn't possible.
Shane32
reviewed
Jun 19, 2024
codebude
reviewed
Jun 20, 2024
codebude
approved these changes
Jun 22, 2024
|
Merged and updated the release notes: https://github.com/codebude/QRCoder/wiki/Release-Notes/_compare/f65174dfcfa139487de893bd439bbd5b659ca48e...9279d42fbdb335d5f8cdb907b7fc077895093ea4 |
|
@Apflkuacha can I ask, how exactly were you attempting to insert the bmp into a PDF? With Acrobat? With itextsharp? |
|
Yeah, that I mentioned withoud details. I was using PDFsharp to insert that bmp and with the old header it couldn't identify the image and with the newer header it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated the Bitmap header from BITMAPCOREHEADER to BITMAPINFOHEADER according to https://en.wikipedia.org/wiki/BMP_file_format#DIB_header_(bitmap_information_header)
Slightly newer version, now with bitmap size in header.
What existing problem does the pull request solve?**
Updating the header was necessary as inserting the previous version of the BMP wasn't possible into a PDF document.