Add NRT metadata #559
Merged
Add NRT metadata #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shane32
commented
Jun 1, 2024
Shane32
commented
Jun 1, 2024
Shane32
commented
Jun 1, 2024
Shane32
commented
Jun 1, 2024
16 tasks
codebude
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds nullable reference type (NRT) metadata to all members
Notes
This upgrades the C# version enough to support NRT. NRT is not incompatible with older frameworks, and no new features are being used that would cause an issue.
Test plan
Existing tests demonstrate compatibility. Existing API tests demonstrate new NRT metadata exposed with no source/binary breaking API changes.