Create Service object for Invitations management

This is an ugly first pass - I've just moved all the code out of the controller and into a new Ruby object. The tests still pass, which is a good start. The next step will be to look at whether there's more refactoring that can be done - for example, does the workshop need to be decorated on l.6? It enables email sending, but that might be a separate concern

Signed-off-by: jonathan.kerr <3410350+jonodrew@users.noreply.github.com>

Author: jonodrew

app/controllers/admin/invitations_controller.rb

@@ -2,11 +2,11 @@ class Admin::InvitationsController < Admin::ApplicationController
   include Admin::WorkshopConcerns
 
   def update
-    set_and_decorate_workshop
+    @invitation_manager = Managers::InvitationManager.new(params[:workshop_id], invitation_id, current_user)
+    @workshop = WorkshopPresenter.decorate(@invitation_manager.workshop)
     authorize @workshop
-    set_invitation
-
-    message = update_attendance(attending: params[:attending], attended: params[:attended])
+    @invitation = @invitation_manager.invitation
+    message = @invitation_manager.update_attendance(attending: params[:attending], attended: params[:attended])
 
     if request.xhr?
       set_admin_workshop_data
@@ -18,64 +18,6 @@ def update
 
   private
 
-  def update_attendance(attending:, attended:)
-    return update_to_attended if attended
-
-    result = attending.eql?('true') ? update_to_attending : update_to_not_attending
-    message, error = result.values_at(:message, :error)
-
-    unless error
-      waiting_listed = WaitingList.find_by(invitation: @invitation)
-      waiting_listed&.destroy
-    end
-
-    message
-  end
-
-  def update_to_attended
-    @invitation.update(attended: true)
-
-    "You have verified #{@invitation.member.full_name}’s attendace."
-  end
-
-  def update_to_attending
-    update_successful = @invitation.update(
-      attending: true,
-      rsvp_time: Time.zone.now,
-      automated_rsvp: true,
-      last_overridden_by_id: current_user.id
-    )
-
-    {
-      message: update_successful ? attending_successful : attending_failed,
-      error: !update_successful
-    }
-  end
-
-  def attending_successful
-    @workshop.send_attending_email(@invitation) if @workshop.future?
-
-    "You have added #{@invitation.member.full_name} to the workshop as a #{@invitation.role}."
-  end
-
-  def attending_failed
-    "Error adding #{@invitation.member.full_name} as a #{@invitation.role}. "\
-      "#{@invitation.errors.full_messages.to_sentence}."
-  end
-
-  def update_to_not_attending
-    @invitation.update!(attending: false, last_overridden_by_id: current_user.id)
-
-    {
-      message: "You have removed #{@invitation.member.full_name} from the workshop.",
-      error: false
-    }
-  end
-
-  def set_invitation
-    @invitation = @workshop.invitations.find_by(token: invitation_id)
-  end
-
   def invitation_id
     params.key?(:workshop) ? params[:workshop][:invitations] : params[:id]
   end

app/services/managers/invitation_manager.rb

@@ -0,0 +1,66 @@
+  # frozen_string_literal: true
+  module Managers
+    class InvitationManager
+      attr_reader :workshop, :invitation
+      def initialize(workshop_id, invitation_id, current_user)
+        @workshop = WorkshopPresenter.decorate(Workshop.find(workshop_id))
+        @invitation = @workshop.invitations.find_by(token: invitation_id)
+        @current_user = current_user
+      end
+
+      def update_attendance(attending:, attended:)
+        return update_to_attended if attended
+
+        result = attending.eql?('true') ? update_to_attending : update_to_not_attending
+        message, error = result.values_at(:message, :error)
+
+        unless error
+          waiting_listed = WaitingList.find_by(invitation: @invitation)
+          waiting_listed&.destroy
+        end
+
+        message
+      end
+
+      private
+      def update_to_attended
+        @invitation.update(attended: true)
+
+        "You have verified #{@invitation.member.full_name}’s attendance."
+      end
+
+      def update_to_attending
+        update_successful = @invitation.update(
+          attending: true,
+          rsvp_time: Time.zone.now,
+          automated_rsvp: true,
+          last_overridden_by_id: @current_user.id
+        )
+
+        {
+          message: update_successful ? attending_successful : attending_failed,
+          error: !update_successful
+        }
+      end
+
+      def update_to_not_attending
+        @invitation.update!(attending: false, last_overridden_by_id: @current_user.id)
+
+        {
+          message: "You have removed #{@invitation.member.full_name} from the workshop.",
+          error: false
+        }
+      end
+
+      def attending_successful
+        @workshop.send_attending_email(@invitation) if @workshop.future?
+
+        "You have added #{@invitation.member.full_name} to the workshop as a #{@invitation.role}."
+      end
+
+      def attending_failed
+        "Error adding #{@invitation.member.full_name} as a #{@invitation.role}. "\
+          "#{@invitation.errors.full_messages.to_sentence}."
+      end
+    end
+  end