Merge pull request #2478 from mroderick/params-expect-part-deux

feat: complete params.expect migration for remaining controllers

Author: olleolleolle

app/controllers/concerns/workshop_invitation_concerns.rb

@@ -11,7 +11,11 @@ module InstanceMethods
     private
 
     def invitation_params
-      params[:workshop_invitation].present? ? params.require(:workshop_invitation).permit(:tutorial, :note) : {}
+      if params.key?(:workshop_invitation)
+        params.expect(workshop_invitation: [:tutorial, :note])
+      else
+        {}
+      end
     end
 
     def back_with_message(message)

app/controllers/contact_preferences_controller.rb

@@ -23,7 +23,7 @@ def token
   end
 
   def contact_preferences
-    params.require(:contact).permit(:token, :mailing_list_consent)
+    params.expect(contact: [:token, :mailing_list_consent])
   end
 
   def mailing_list_consent

app/controllers/feedback_controller.rb

@@ -34,7 +34,7 @@ def submit
   private
 
   def feedback_params
-    params.require(:feedback).permit(:coach_id, :tutorial_id, :request, :rating, :suggestions)
+    params.expect(feedback: [:coach_id, :tutorial_id, :request, :rating, :suggestions])
   end
 
   def set_coaches(workshop)

app/controllers/invitation_controller.rb

@@ -21,7 +21,11 @@ def update
   private
 
   def invitation_params
-    params[:workshop_invitation].present? ? params.require(:workshop_invitation).permit(:tutorial, :note) : {}
+    if params.key?(:workshop_invitation)
+      params.expect(workshop_invitation: [:tutorial, :note])
+    else
+      {}
+    end
   end
 
   def available_spaces?(workshop, invitation)

app/controllers/subscriptions_controller.rb

@@ -37,7 +37,7 @@ def destroy
   private
 
   def group_id
-    params.require(:subscription).permit(:group_id)[:group_id]
+    params.expect(subscription: [:group_id])[:group_id]
   end
 
   def send_welcome_email(member, subscription)

app/controllers/terms_and_conditions_controller.rb

@@ -22,6 +22,6 @@ def update
   private
 
   def terms_params
-    params.require(:terms_and_conditions_form).permit(:terms)
+    params.expect(terms_and_conditions_form: [:terms])
   end
 end