main/production #21
Merged
main/production #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes responsive breakpoints for navigation components, centralizes the language switcher into the main navigation, adjusts image container sizes for consistency, and updates a seeded contact email.
- Aligns navigation breakpoint switches from
mdtolgand removes the desktop-specific language menu - Centralizes logo and language selector in the main navigation layout
- Updates default and overridden image container dimensions in list-image-card and about-us page
- Updates a seeded contact email address
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| resources/views/layouts/_partials/_navigation_mobile.blade.php | Changed mobile nav breakpoint from md:hidden to lg:hidden |
| resources/views/layouts/_partials/_navigation_desktop.blade.php | Updated desktop nav from md:flex to lg:flex and removed language switcher |
| resources/views/layouts/_partials/_navigation.blade.php | Refactored nav to include centralized language selector and use lg:hidden for toggle |
| resources/views/components/list-image-card.blade.php | Adjusted default image container size and added flex-row class |
| resources/views/app/about-us/index.blade.php | Updated image-card override size from h-20 w-20 to h-24 w-24 |
| database/seeders/Paperflakes/ContactsTableSeeder.php | Updated seeded contact email |
|
|
||
| <div class="flex rounded-xl overflow-hidden transition | ||
| group"> | ||
| <div class="flex flex-row rounded-xl overflow-hidden transition group"> |
There was a problem hiding this comment.
[nitpick] The flex-row class is redundant because flex defaults to row direction; consider removing it for brevity and clarity.
Suggested change
| <div class="flex flex-row rounded-xl overflow-hidden transition group"> | |
| <div class="flex rounded-xl overflow-hidden transition group"> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.