Skip to content

Feature/cm 965 add image asset protocol #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jan 3, 2023

Conversation

devkaranCT
Copy link
Contributor

Introduction

'ImageAsset' protocol added to load image.

Purpose

Added a protocol 'ImageAsset' with default properties and functions in it, which will return the image loaded from the asset catalog.

Scope

Updated production code and Test code.

📈 Coverage

Code

Screenshot 2022-12-23 at 11 16 59 AM

@devkaranCT devkaranCT self-assigned this Dec 23, 2022
@devkaranCT devkaranCT added the enhancement New feature or request label Dec 23, 2022
Copy link
Contributor

@mpospese mpospese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename Image.xcassets to Images.xcassets (plural) to match the other naming.

@devkaranCT devkaranCT force-pushed the feature/CM-965-addImageAssetProtocol branch from 8521a8f to ed3e7d6 Compare January 3, 2023 09:12
@mpospese mpospese force-pushed the feature/CM-965-addImageAssetProtocol branch from ed3e7d6 to d0c64a7 Compare January 3, 2023 09:19
@devkaranCT devkaranCT requested a review from mpospese January 3, 2023 09:24
@mpospese mpospese linked an issue Jan 3, 2023 that may be closed by this pull request
Copy link
Contributor

@mpospese mpospese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks Dev. You can go ahead and merge this in. (We don't have squash merging enabled on this repo, so rebase merging will be fine.)

@devkaranCT devkaranCT merged commit af09946 into main Jan 3, 2023
@devkaranCT devkaranCT deleted the feature/CM-965-addImageAssetProtocol branch January 3, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

Add ImageAsset protocol
2 participants