-
Notifications
You must be signed in to change notification settings - Fork 7
Feature/cm 965 add image asset protocol #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename Image.xcassets
to Images.xcassets
(plural) to match the other naming.
8521a8f
to
ed3e7d6
Compare
ed3e7d6
to
d0c64a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks Dev. You can go ahead and merge this in. (We don't have squash merging enabled on this repo, so rebase merging will be fine.)
Introduction
'ImageAsset' protocol added to load image.
Purpose
Added a protocol 'ImageAsset' with default properties and functions in it, which will return the image loaded from the asset catalog.
Scope
Updated production code and Test code.
📈 Coverage
Code