-
Notifications
You must be signed in to change notification settings - Fork 7
[CM -866] Expand localizable with tableName #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
PanchamiShenoy
merged 1 commit into
main
from
panchami/CM-866-expand-localizable-with-tablename
Oct 28, 2022
Merged
[CM -866] Expand localizable with tableName #25
PanchamiShenoy
merged 1 commit into
main
from
panchami/CM-866-expand-localizable-with-tablename
Oct 28, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpospese
reviewed
Oct 27, 2022
Tests/YCoreUITests/Extensions/Foundation/String+LocalizedTests.swift
Outdated
Show resolved
Hide resolved
Tests/YCoreUITests/Extensions/Foundation/String+LocalizedTests.swift
Outdated
Show resolved
Hide resolved
Tests/YCoreUITests/Extensions/Foundation/String+LocalizedTests.swift
Outdated
Show resolved
Hide resolved
mpospese
reviewed
Oct 27, 2022
5880ff7
to
6c64f94
Compare
mpospese
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
Expand localizable with tableName
Purpose
tablename specifies which strings file to load the strings from
Scope
added tableName parameter to localized method and unit test to test it