[UPDATE] review comments resolved

Author: SahilSainiYML

Sources/YCoreUI/Extensions/UIKit/UIColor+rgbComponents.swift

@@ -10,7 +10,7 @@ import UIKit
 
 // This relatively simple tuple (four float values representing the color channels)
 // is already a released public api.
-// swiftlint:disable superfluous_disable_command large_tuple
+// swiftlint: disable large_tuple
 
 /// Tuple representing Red, Green, Blue, and Alpha color channel components
 public typealias RGBAComponents = (red: CGFloat, green: CGFloat, blue: CGFloat, alpha: CGFloat)
@@ -29,4 +29,4 @@ public extension UIColor {
         return (red, green, blue, alpha)
     }
 }
-// swiftlint: enable superfluous_disable_command large_tuple
+// swiftlint: enable large_tuple

Sources/YCoreUI/Protocols/ImageAsset.swift

@@ -20,10 +20,7 @@ public protocol ImageAsset: RawRepresentable where RawValue == String {
 
     /// Optional namespace for the image assets (default is `nil`).
     static var namespace: String? { get }
-
-    /// Optional renderingMode to use for the image (default is `nil`)
-    static var renderingMode: UIImage.RenderingMode? { get }
-
+    
     /// Fallback image to use in case an image asset cannot be loaded.
     /// (default is a 16 x 16 square filled with `.systemPink`)
     static var fallbackImage: UIImage { get }
@@ -42,10 +39,7 @@ public protocol ImageAsset: RawRepresentable where RawValue == String {
 extension ImageAsset {
     /// The bundle containing the image assets for this enum (default is `.main`)
     public static var bundle: Bundle { .main }
-
-    /// Optional renderingMode to use for the image (default is `nil`)
-    public static var renderingMode: UIImage.RenderingMode? { nil }
-
+    
     /// Optional namespace for the image assets (default is `nil`)
     public static var namespace: String? { nil }
 
@@ -66,11 +60,7 @@ extension ImageAsset {
     /// (prepended to `rawValue`) and `bundle`.
     /// - Returns: The named image or else `nil` if the named asset cannot be loaded.
     public func loadImage() -> UIImage? {
-        let image = UIImage(named: calculateName(), in: Self.bundle, compatibleWith: nil)
-        guard let renderingMode = Self.renderingMode else {
-            return image
-        }
-        return image?.withRenderingMode(renderingMode)
+        UIImage(named: calculateName(), in: Self.bundle, compatibleWith: nil)
     }
 
     internal func calculateName() -> String {

Sources/YCoreUI/Protocols/SystemImage.swift

@@ -17,6 +17,9 @@ public protocol SystemImage: RawRepresentable where RawValue == String {
     /// (default is a 16 x 16 square filled with `.systemPink`)
     static var fallbackImage: UIImage { get }
 
+    /// Optional rendering mode to use for the image (default is `nil`)
+    static var renderingMode: UIImage.RenderingMode? { get }
+
     /// A system image for this name value.
     ///
     /// Default implementation calls `loadImage` and nil-coalesces to `fallbackImage`.
@@ -41,7 +44,10 @@ public protocol SystemImage: RawRepresentable where RawValue == String {
 extension SystemImage {
     /// Image will scale according to the specified text style.
     public static var textStyle: UIFont.TextStyle? { .body }
-    
+
+    /// Optional rendering mode to use for the image (default is `nil`)
+    public static var renderingMode: UIImage.RenderingMode? { nil }
+
     /// Image configuration to be used in `loadImage()`.
     ///
     /// Returns `nil` when `textStyle` is `nil`.
@@ -68,7 +74,11 @@ extension SystemImage {
     /// Default implementation uses `UIImage(systemName:)` passing in the associated `rawValue`.
     /// - Returns: The named system image or else `nil` if the system image cannot be loaded.
     public func loadImage() -> UIImage? {
-        UIImage(systemName: rawValue, withConfiguration: Self.configuration)
+        let image = UIImage(systemName: rawValue, withConfiguration: Self.configuration)
+        guard let renderingMode = Self.renderingMode else {
+            return image
+        }
+        return image?.withRenderingMode(renderingMode)
     }
 
     /// A system image for this name value.

Tests/YCoreUITests/Extensions/Foundation/CGFloat+roundedTests.swift

@@ -10,7 +10,7 @@ import XCTest
 @testable import YCoreUI
 
 // Large tuples help us build unit test expectations concisely
-// swiftlint:disable superfluous_disable_command large_tuple
+// swiftlint: disable large_tuple
 
 final class CGFloatRoundedTests: XCTestCase {
     typealias ScalingInputs = (
@@ -75,4 +75,4 @@ final class CGFloatRoundedTests: XCTestCase {
         }
     }
 }
-// swiftlint: enable large_tuple superfluous_disable_command
+// swiftlint: enable large_tuple

Tests/YCoreUITests/Extensions/UIKit/UIColor+WCAGTests.swift

@@ -10,7 +10,7 @@ import XCTest
 @testable import YCoreUI
 
 // Large tuples help us build unit test expectations concisely
-// swiftlint:disable superfluous_disable_command large_tuple
+// swiftlint: disable large_tuple
 
 final class UIColorWCAGTests: XCTestCase {
     typealias ColorInputs = (foreground: UIColor, background: UIColor, context: WCAGContext)
@@ -183,4 +183,4 @@ final class UIColorWCAGTests: XCTestCase {
         XCTAssertEqual(round(ratio1 * 100) / 100, round(ratio2 * 100) / 100)
     }
 }
-// swiftlint: enable large_tuple superfluous_disable_command
+// swiftlint: enable large_tuple

Tests/YCoreUITests/Extensions/UIKit/UIColor+rgbValueTests.swift

@@ -10,7 +10,7 @@ import XCTest
 @testable import YCoreUI
 
 // Large tuples help us build unit test expectations concisely
-// swiftlint:disable superfluous_disable_command large_tuple
+// swiftlint: disable large_tuple
 
 final class UIColorRgbValueTests: XCTestCase {
     typealias ColorTest = (color: UIColor, prefix: String?, isUppercase: Bool, output: String)
@@ -75,4 +75,4 @@ final class UIColorRgbValueTests: XCTestCase {
         YCoreUI.isLoggingEnabled = true
     }
 }
-// swiftlint: enable large_tuple superfluous_disable_command
+// swiftlint: enable large_tuple

Tests/YCoreUITests/Extensions/UIKit/UIView+constrainAnchorTests.swift

@@ -9,8 +9,6 @@
 import XCTest
 @testable import YCoreUI
 
-// swiftlint:disable superfluous_disable_command type_body_length
-
 final class UIViewConstrainAnchorTests: XCTestCase {
     func testXAxisConstraints() {
         let (sut, relations) = makeSUT()
@@ -380,4 +378,3 @@ private extension MockLayoutContainer {
         addSubview(view2)
     }
 }
-// swiftlint:enable superfluous_disable_command type_body_length

Tests/YCoreUITests/Extensions/UIKit/UIView+constrainEdgesTests.swift

@@ -8,7 +8,6 @@
 
 import XCTest
 
-// swiftlint:disable superfluous_disable_command
 final class UIViewConstrainEdgesTests: XCTestCase {
     func testSimple() {
         let (sut, insets) = makeSUT()
@@ -51,7 +50,6 @@ final class UIViewConstrainEdgesTests: XCTestCase {
         XCTAssertEqual(trailing?.secondAttribute, .trailing)
         XCTAssertEqual(trailing?.constant, -insets.trailing)
     }
-    // swiftlint:disable function_body_length
     func testPartialEdges() {
         let (sut, _) = makeSUT()
         let edges: [NSDirectionalRectEdge] = [
@@ -115,8 +113,7 @@ final class UIViewConstrainEdgesTests: XCTestCase {
             button.removeFromSuperview()
         }
     }
-    // swiftlint:enable function_body_length
-
+    
     func testRelation() {
         let (sut, _) = makeSUT()
         let relations: [(input: NSLayoutConstraint.Relation, inverse: NSLayoutConstraint.Relation)] = [
@@ -178,4 +175,3 @@ private extension UIViewConstrainEdgesTests {
         return (container, insets)
     }
 }
-// swiftlint: enable superfluous_disable_command

Tests/YCoreUITests/Protocols/ImageAssetTests.swift

@@ -40,12 +40,6 @@ final class ImageAssetTests: XCTestCase {
             XCTAssertNotEqual($0.image.pngData(), DefaultImageAssets.fallbackImage.pngData())
         }
     }
-
-    func test_loadImageWithRenderingMode() {
-        RenderMode.allCases.forEach {
-            XCTAssertNotNil($0.loadImage())
-        }
-    }
 
     func test_missingImage() {
         YCoreUI.isLoggingEnabled = false
@@ -106,13 +100,4 @@ extension ImageAssetTests {
             return image
         }
     }
-
-    enum RenderMode: String, CaseIterable, ImageAsset {
-        case unitedStates = "flag_us"
-        case india = "flag_in"
-        case switzerland = "flag_ch"
-
-        static var bundle: Bundle { .module }
-        static var renderingMode: UIImage.RenderingMode? { .alwaysOriginal }
-    }
 }

Tests/YCoreUITests/Protocols/SystemImageTests.swift

@@ -33,6 +33,19 @@ final class SystemImageTests: XCTestCase {
         YCoreUI.isLoggingEnabled = true
     }
 
+    func test_loadImageWithRenderingMode() {
+        RenderMode.allCases.forEach {
+            XCTAssertEqual(
+                $0.loadImage()?.pngData(),
+                UIImage(
+                    systemName: $0.rawValue,
+                    withConfiguration: RenderMode.configuration
+                )?.withRenderingMode(RenderMode.renderingMode ?? .alwaysTemplate).pngData()
+            )
+            XCTAssertEqual($0.image.renderingMode, .alwaysOriginal)
+        }
+    }
+
     func test_defaultImageScaling() {
         XCTAssertEqual(Symbols.textStyle, .body)
         XCTAssertEqual(Symbols.configuration, UIImage.SymbolConfiguration(textStyle: .body))
@@ -88,4 +101,12 @@ extension SystemImageTests {
 
         static var textStyle: UIFont.TextStyle? { .title1 }
     }
+
+    enum RenderMode: String, CaseIterable, SystemImage {
+        case plus
+        case minus
+        case trash
+
+        static var renderingMode: UIImage.RenderingMode? { .alwaysOriginal }
+    }
 }