[CM-757] Create a SwiftLint Plugin for a Swift Package #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpospese
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
Add
SwiftLintplugin to Swift Package.Purpose
In order to see warnings and errors in Xcode when using
SwiftLintin a Swift Package, we need to create a plugin that will run theSwiftLinttool at build time. This PR creates a plugin that will do that by using theSwiftLintbinary. Using the binary instead of pulling in theSwiftLintpackage as a dependency will reduce the build time. In the future, we could pull this out into its own package to be used in all our swift packages. This is possible today but there are issues in Xcode that prevent it from reliably showing warnings in Xcode. This is being resolved in Xcode 14 and should be out in the Fall.