Fix address tag resolution #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@scottatron great work. We'll merge it asap. May I keen to ask you to open a bug too to follow the process. It will help others to understand what the issue is, how it can be reproduced and what versions are affected. |
|
Ah sorry, I should have read the CONTRIBUTING guide a little more closely. I'll get an issue raised and update the |
|
This change addresses #57 |
Tags returned from the API do not have a 'tag' attribute—the tag value is returned in the 'type' attribute. This introduces a special case for tag lookups to allow the filter_by value to be overridden. Fixes codeaffen#57
scottatron
force-pushed
the
fix-tag-lookups
branch
from
c7b2ce3 to
55c1b7d
Compare
cmeissner
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tags returned from the API do not have a 'tag' attribute—the tag value is returned in the 'type' attribute.
This introduces a special case for tag lookups to allow the
filter_byvalue to be overridden.