Skip to content

Implement folder module #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Implement folder module #103

merged 2 commits into from
Aug 28, 2023

Conversation

cmeissner
Copy link
Member

@cmeissner cmeissner commented Aug 26, 2023

  • add code to resolve folders and parent folders
  • add folder module
  • add folder and parent folder test cases
  • update documentation

Resolves #100, resolves #101

@cmeissner cmeissner self-assigned this Aug 26, 2023
@cmeissner cmeissner added documentation Improvements or additions to documentation enhancement New feature or request accepted This issue can reproduced and was accepted labels Aug 26, 2023
@cmeissner cmeissner force-pushed the bugfix/100 branch 2 times, most recently from 538819f to 9a80906 Compare August 26, 2023 10:09
@cmeissner cmeissner requested a review from gmzabos August 26, 2023 10:32
- add code to resolve folders and parent folders
- add folder module
- add folder and parent folder test cases
- update documentation

Resolves codeaffen#100
Copy link
Member

@gmzabos gmzabos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmeissner cmeissner merged commit 8add688 into codeaffen:develop Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted This issue can reproduced and was accepted documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to create subnet in folder folder creation is not idempotent
2 participants