[IOTDB-3771] Fix cannot take snapshot when the data dir and snapshot dir is on different disk (apache#6782)

Author: THUMarkLau

node-commons/src/main/java/org/apache/iotdb/commons/utils/FileUtils.java

@@ -136,4 +136,21 @@ public static long getDirSize(String path) {
     }
     return sum;
   }
+
+  public static void recursiveDeleteFolder(String path) throws IOException {
+    File file = new File(path);
+    if (file.isDirectory()) {
+      File[] files = file.listFiles();
+      if (files == null || files.length == 0) {
+        org.apache.commons.io.FileUtils.deleteDirectory(file);
+      } else {
+        for (File f : files) {
+          recursiveDeleteFolder(f.getAbsolutePath());
+        }
+        org.apache.commons.io.FileUtils.deleteDirectory(file);
+      }
+    } else {
+      org.apache.commons.io.FileUtils.delete(file);
+    }
+  }
 }

server/pom.xml

@@ -223,6 +223,12 @@
             <groupId>com.google.guava</groupId>
             <artifactId>guava</artifactId>
         </dependency>
+        <dependency>
+            <groupId>org.apache.iotdb</groupId>
+            <artifactId>node-commons</artifactId>
+            <version>${project.version}</version>
+            <scope>compile</scope>
+        </dependency>
     </dependencies>
     <build>
         <plugins>

server/src/main/java/org/apache/iotdb/db/conf/IoTDBConfig.java

@@ -1156,7 +1156,7 @@ public String[] getDataDirs() {
     return dataDirs;
   }
 
-  void setDataDirs(String[] dataDirs) {
+  public void setDataDirs(String[] dataDirs) {
     this.dataDirs = dataDirs;
   }
 

server/src/main/java/org/apache/iotdb/db/conf/directories/DirectoryManager.java

@@ -19,6 +19,7 @@
 package org.apache.iotdb.db.conf.directories;
 
 import org.apache.iotdb.commons.conf.IoTDBConstant;
+import org.apache.iotdb.commons.utils.TestOnly;
 import org.apache.iotdb.db.conf.IoTDBDescriptor;
 import org.apache.iotdb.db.conf.SystemStatus;
 import org.apache.iotdb.db.conf.directories.strategy.DirectoryStrategy;
@@ -175,6 +176,22 @@ public List<String> getAllFilesFolders() {
     return folders;
   }
 
+  @TestOnly
+  public void resetFolders() {
+    sequenceFileFolders =
+        new ArrayList<>(Arrays.asList(IoTDBDescriptor.getInstance().getConfig().getDataDirs()));
+    for (int i = 0; i < sequenceFileFolders.size(); i++) {
+      sequenceFileFolders.set(
+          i, sequenceFileFolders.get(i) + File.separator + IoTDBConstant.SEQUENCE_FLODER_NAME);
+    }
+    unsequenceFileFolders =
+        new ArrayList<>(Arrays.asList(IoTDBDescriptor.getInstance().getConfig().getDataDirs()));
+    for (int i = 0; i < unsequenceFileFolders.size(); i++) {
+      unsequenceFileFolders.set(
+          i, unsequenceFileFolders.get(i) + File.separator + IoTDBConstant.UNSEQUENCE_FLODER_NAME);
+    }
+  }
+
   private static class DirectoriesHolder {
     private static final DirectoryManager INSTANCE = new DirectoryManager();
   }

server/src/main/java/org/apache/iotdb/db/consensus/statemachine/DataRegionStateMachine.java

@@ -48,6 +48,7 @@
 import org.slf4j.LoggerFactory;
 
 import java.io.File;
+import java.io.IOException;
 import java.util.ArrayList;
 import java.util.LinkedList;
 import java.util.List;
@@ -97,7 +98,7 @@ public boolean takeSnapshot(File snapshotDir) {
     } catch (Exception e) {
       logger.error(
           "Exception occurs when taking snapshot for {}-{} in {}",
-          region.getLogicalStorageGroupName(),
+          region.getStorageGroupName(),
           region.getDataRegionId(),
           snapshotDir,
           e);
@@ -110,7 +111,7 @@ public void loadSnapshot(File latestSnapshotRootDir) {
     DataRegion newRegion =
         new SnapshotLoader(
                 latestSnapshotRootDir.getAbsolutePath(),
-                region.getLogicalStorageGroupName(),
+                region.getStorageGroupName(),
                 region.getDataRegionId())
             .loadSnapshotForStateMachine();
     if (newRegion == null) {
@@ -258,8 +259,20 @@ private InsertNode grabInsertNode(IndexedConsensusRequest indexedRequest) {
 
   @Override
   public List<File> getSnapshotFiles(File latestSnapshotRootDir) {
-    // TODO: implement this method
-    return super.getSnapshotFiles(latestSnapshotRootDir);
+    try {
+      return new SnapshotLoader(
+              latestSnapshotRootDir.getAbsolutePath(),
+              region.getStorageGroupName(),
+              region.getDataRegionId())
+          .getSnapshotFileInfo();
+    } catch (IOException e) {
+      logger.error(
+          "Meets error when getting snapshot files for {}-{}",
+          region.getStorageGroupName(),
+          region.getDataRegionId(),
+          e);
+      return null;
+    }
   }
 
   @Override

server/src/main/java/org/apache/iotdb/db/engine/StorageEngine.java

@@ -1113,7 +1113,7 @@ public void mergeUnLock(List<DataRegion> list) {
   public String getStorageGroupPath(PartialPath path) throws StorageEngineException {
     PartialPath deviceId = path.getDevicePath();
     DataRegion storageGroupProcessor = getProcessor(deviceId);
-    return storageGroupProcessor.getLogicalStorageGroupName()
+    return storageGroupProcessor.getStorageGroupName()
         + File.separator
         + storageGroupProcessor.getDataRegionId();
   }

server/src/main/java/org/apache/iotdb/db/engine/StorageEngineV2.java

@@ -540,7 +540,7 @@ public void forceCloseAllProcessor() throws TsFileProcessorException {
 
   public void closeStorageGroupProcessor(String storageGroupPath, boolean isSeq) {
     for (DataRegion dataRegion : dataRegionMap.values()) {
-      if (dataRegion.getLogicalStorageGroupName().equals(storageGroupPath)) {
+      if (dataRegion.getStorageGroupName().equals(storageGroupPath)) {
         if (isSeq) {
           for (TsFileProcessor tsFileProcessor : dataRegion.getWorkSequenceTsFileProcessors()) {
             dataRegion.syncCloseOneTsFileProcessor(isSeq, tsFileProcessor);
@@ -662,14 +662,12 @@ public void deleteDataRegion(DataRegionId regionId) {
                 .equals(ConsensusFactory.MultiLeaderConsensus)) {
           WALManager.getInstance()
               .deleteWALNode(
-                  region.getLogicalStorageGroupName()
-                      + FILE_NAME_SEPARATOR
-                      + region.getDataRegionId());
+                  region.getStorageGroupName() + FILE_NAME_SEPARATOR + region.getDataRegionId());
         }
       } catch (Exception e) {
         logger.error(
             "Error occurs when deleting data region {}-{}",
-            region.getLogicalStorageGroupName(),
+            region.getStorageGroupName(),
             region.getDataRegionId(),
             e);
       } finally {

server/src/main/java/org/apache/iotdb/db/engine/snapshot/SnapshotFileSet.java

@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.db.engine.snapshot;
+
+import org.apache.iotdb.db.engine.modification.ModificationFile;
+import org.apache.iotdb.db.engine.storagegroup.TsFileResource;
+import org.apache.iotdb.tsfile.common.constant.TsFileConstant;
+
+import java.io.File;
+import java.util.Arrays;
+import java.util.HashSet;
+import java.util.Set;
+
+public class SnapshotFileSet {
+  public static final String[] DATA_FILE_SUFFIX =
+      new String[] {
+        TsFileConstant.TSFILE_SUFFIX, TsFileResource.RESOURCE_SUFFIX, ModificationFile.FILE_SUFFIX,
+      };
+
+  private static final Set<String> DATA_FILE_SUFFIX_SET =
+      new HashSet<>(Arrays.asList(DATA_FILE_SUFFIX));
+
+  public static boolean isDataFile(File file) {
+    String[] fileName = file.getName().split("\\.");
+    return DATA_FILE_SUFFIX_SET.contains(fileName[fileName.length - 1]);
+  }
+}