Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we have the expert-to-expert transactions integrated? #57

Open
loopzloopz opened this issue Jun 22, 2021 · 9 comments
Open

Can we have the expert-to-expert transactions integrated? #57

loopzloopz opened this issue Jun 22, 2021 · 9 comments

Comments

@loopzloopz
Copy link

Pretty pretty please! :)

I assume it is a challenge to count in the ones a user would send to a colleague,
but it would be great if the stats would update the $ amount with the transactions received from other colleagues.

In essence, that's the more important angle - if we were to measure one VS the other :)

Pretty please! :D

@PanosSynetos
Copy link
Contributor

hey @loopzloopz

Wouldn't it be awesome to do a PR for it? Or anyone else who actually benefits from the expert to expert transfers? :)

I don't have any expert to expert transfers on my account to test it out, and I don't plan to have any in the near future.

First, I'd recommend you check if these data are available in an API call. If they are, then it should be straight forward

  • Consider the expert a client
  • Store hem in the clients table
  • Store the transaction in the transactions table

There you are :)

If you want to make it more fancy, you can flag the client as "expert" and the transaction as "expert" so you can have different tables (clients / experts) and have different graphs stats (experts vs clients)

Let me know if you need any further help, happy to jump in a call with you (or whoever else wants to participate) and help out, but I cannot develop it right now

@loopzloopz
Copy link
Author

Thank you, my brother from another mother! :)

I'm basically "API illiterate" but I'm gonna harass a couple of Codeablers to do this for us :p

@atwellpub
Copy link

atwellpub commented Jun 22, 2021

Is this request different from this?
image

Source: https://community.codeable.io/t/expert-community-update-june-2021/2222

@PanosSynetos
Copy link
Contributor

Yes @atwellpub - That's exactly it. And for this functionality, we need to know the relevant API calls and JSON returns, that we need to do in our plugin, in order to show the expert to expert funds.

Currently, our plugin only tracks funds that we as experts receive from clients (normal and additional tasks). It doesn't show the funds we receive from other experts, and we'd like to implement this.

Any insights you can share @atwellpub , feel free :)

@atwellpub
Copy link

@kirilhristov @depy

Tagging the product team for more information. Good luck!

@kirilhristov
Copy link

I'm not sure this will help, but expert-to-expert transfers show up just like all other transactions, except the description is "ad_hoc_team_work".

image

  {
    "id": 201044,
    "description": "ad_hoc_team_work",
    "timestamp": 1622105083,
    "task_type": "Task",
    "created_at": "2021-05-27T08:44:43.390Z",
    "amount": 100,
    "fee_percentage": 0,
    "fee_amount": 0,
    "full_refund_correction_prior_to_fee_fix": 0,
    "payment_details": null,
    "debited_account_id": 661,
    "debited_account_name": "Danny Vittensonn",
    "credited_account_id": 1819,
    "credited_account_name": "Bogman Rider",
    "credit_amounts": [
      {
        "id": 745330,
        "amount": 100,
        "account": "user_1819"
      }
    ],
    "debit_amounts": [
      {
        "id": 745331,
        "amount": 100,
        "account": "user_661"
      }
    ],
    "task": {
      "id": 111,
      "title": "Single sign on ",
      "kind": "uncategorized",
      "parent_task_id": null,
      "current_user_is_preferred_contractor": false,
      "retainer": false,
      "invoice_url": null
    },
    "task_client": {
      "id": 569,
      "full_name": "Dana R.",
      "role": "client",
      "last_sign_in_at": "2014-07-16T09:05:43.093Z",
      "rsa_public_key": null,
      "pro": false,
      "timezone_offset": 240,
      "status": null,
      "available": null,
      "avatar": {
        "tiny_url": "https://storage.googleapis.com/avatars-staging.codeable.io/default-avatars/tiny.png",
        "small_url": "https://storage.googleapis.com/avatars-staging.codeable.io/default-avatars/small.png",
        "medium_url": "https://storage.googleapis.com/avatars-staging.codeable.io/default-avatars/medium.png",
        "large_url": "https://storage.googleapis.com/avatars-staging.codeable.io/default-avatars/large.png"
      }
    }
  },
  {

@PanosSynetos
Copy link
Contributor

Thanks Kiro. I think it should be enough, anyone who is familiar with the API calls, can dissect the plugin and understand what to do.

On my end, it's not possible to work on it, not before September :(

@loopzloopz
Copy link
Author

Kiro, brato, I like your balance.

Will you marry me?

@PanosSynetos
Copy link
Contributor

Hey @kakoma :) Would you like to have a go at this one, now that you're fresh with your commits? :)

I just merged your PR and bumped up the version. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants