replace: this with appropriate lifecycle owner

app/src/main/java/ro/code4/monitorizarevot/ui/base/BaseAnalyticsFragment.kt

@@ -27,7 +27,7 @@ abstract class BaseAnalyticsFragment : Fragment(), AnalyticsScreenName {
     override fun onResume() {
         super.onResume()
 
-        firebaseAnalytics.setCurrentScreen(activity!!, getString(screenName), null)
+        firebaseAnalytics.setCurrentScreen(requireActivity(), getString(screenName), null)
     }
 
     fun logAnalyticsEvent(event: Event, vararg params: Param) {

app/src/main/java/ro/code4/monitorizarevot/ui/forms/FormsFragment.kt

@@ -37,24 +37,24 @@ class FormsFragment : ViewModelFragment<FormsViewModel>() {
 
     override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
         super.onViewCreated(view, savedInstanceState)
-        viewModel.pollingStation().observe(this, Observer {
+        viewModel.pollingStation().observe(viewLifecycleOwner, Observer {
             pollingStationBarText.text =
                 getString(R.string.polling_station, it.pollingStationNumber, it.countyName)
         })
 
-        viewModel.title().observe(this, Observer {
+        viewModel.title().observe(viewLifecycleOwner, Observer {
             (activity as MainActivity).setTitle(it)
         })
 
-        viewModel.selectedForm().observe(this, Observer {
+        viewModel.selectedForm().observe(viewLifecycleOwner, Observer {
             childFragmentManager.replaceFragment(
                 R.id.content,
                 QuestionsListFragment(),
                 bundleOf(Pair(FORM, Parcels.wrap(it))),
                 QuestionsListFragment.TAG
             )
         })
-        viewModel.selectedQuestion().observe(this, Observer {
+        viewModel.selectedQuestion().observe(viewLifecycleOwner, Observer {
             childFragmentManager.replaceFragment(
                 R.id.content,
                 QuestionsDetailsFragment(),
@@ -65,7 +65,7 @@ class FormsFragment : ViewModelFragment<FormsViewModel>() {
                 QuestionsDetailsFragment.TAG
             )
         })
-        viewModel.navigateToNotes().observe(this, Observer {
+        viewModel.navigateToNotes().observe(viewLifecycleOwner, Observer {
             childFragmentManager.replaceFragment(
                 R.id.content,
                 NoteFragment(),

app/src/main/java/ro/code4/monitorizarevot/ui/forms/FormsListFragment.kt

@@ -41,15 +41,15 @@ class FormsListFragment : ViewModelFragment<FormsViewModel>() {
 
     override fun onAttach(context: Context) {
         super.onAttach(context)
-        viewModel = getSharedViewModel(from = { parentFragment!! })
+        viewModel = getSharedViewModel(from = { requireParentFragment() })
     }
 
     override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
         super.onViewCreated(view, savedInstanceState)
-        viewModel.forms().observe(this, Observer {
+        viewModel.forms().observe(viewLifecycleOwner, Observer {
             formAdapter.items = it
         })
-        viewModel.syncVisibility().observe(this, Observer {
+        viewModel.syncVisibility().observe(viewLifecycleOwner, Observer {
             syncGroup.visibility = it
         })
 

app/src/main/java/ro/code4/monitorizarevot/ui/forms/questions/QuestionsListFragment.kt

@@ -37,16 +37,16 @@ class QuestionsListFragment : ViewModelFragment<QuestionsViewModel>() {
 
     override fun onAttach(context: Context) {
         super.onAttach(context)
-        baseViewModel = getSharedViewModel(from = { parentFragment!! })
+        baseViewModel = getSharedViewModel(from = { requireParentFragment() })
     }
 
     override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
         super.onViewCreated(view, savedInstanceState)
 
-        viewModel.questions().observe(this, Observer {
+        viewModel.questions().observe(viewLifecycleOwner, Observer {
             questionAdapter.items = it
         })
-        viewModel.title().observe(this, Observer {
+        viewModel.title().observe(viewLifecycleOwner, Observer {
             baseViewModel.setTitle(it)
         })
         viewModel.setData(Parcels.unwrap<FormDetails>(arguments?.getParcelable((FORM))))

app/src/main/java/ro/code4/monitorizarevot/ui/notes/NoteFragment.kt

@@ -54,8 +54,8 @@ class NoteFragment : ViewModelFragment<NoteViewModel>(), PermissionManager.Permi
     private lateinit var permissionManager: PermissionManager
     override fun onAttach(context: Context) {
         super.onAttach(context)
-        permissionManager = PermissionManager(activity!!, this)
-        baseViewModel = getSharedViewModel(from = { parentFragment!! })
+        permissionManager = PermissionManager(requireActivity(), this)
+        baseViewModel = getSharedViewModel(from = { requireParentFragment() })
     }
 
     override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
@@ -68,15 +68,15 @@ class NoteFragment : ViewModelFragment<NoteViewModel>(), PermissionManager.Permi
                 .color(Color.TRANSPARENT)
                 .sizeResId(R.dimen.small_margin).build()
         )
-        viewModel.title().observe(this, Observer {
+        viewModel.title().observe(viewLifecycleOwner, Observer {
             baseViewModel.setTitle(it)
         })
 
         viewModel.setData(Parcels.unwrap<Question>(arguments?.getParcelable((Constants.QUESTION))))
-        viewModel.notes().observe(this, Observer {
+        viewModel.notes().observe(viewLifecycleOwner, Observer {
             noteAdapter.items = it
         })
-        viewModel.filesNames().observe(this, Observer {
+        viewModel.filesNames().observe(viewLifecycleOwner, Observer {
             noteFileContainer.visibility = View.VISIBLE
             noteFileContainer.removeAllViews()
             it.forEach { filename ->

app/src/main/java/ro/code4/monitorizarevot/ui/section/details/PollingStationDetailsFragment.kt

@@ -36,7 +36,7 @@ class PollingStationDetailsFragment : ViewModelFragment<PollingStationViewModel>
 
     override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
         super.onViewCreated(view, savedInstanceState)
-        viewModel.pollingStation().observe(this, Observer {
+        viewModel.pollingStation().observe(viewLifecycleOwner, Observer {
             pollingStationBarText.text = it
         })
         viewModel.setTitle(getString(R.string.title_polling_station))
@@ -45,10 +45,10 @@ class PollingStationDetailsFragment : ViewModelFragment<PollingStationViewModel>
             viewModel.notifyChangeRequested()
             activity?.onBackPressed()
         }
-        viewModel.departureTime().observe(this, Observer {
+        viewModel.departureTime().observe(viewLifecycleOwner, Observer {
             departureTime.text = it
         })
-        viewModel.arrivalTime().observe(this, Observer {
+        viewModel.arrivalTime().observe(viewLifecycleOwner, Observer {
             arrivalTime.text = it
         })
         arrivalTime.setOnClickListener {
@@ -83,7 +83,7 @@ class PollingStationDetailsFragment : ViewModelFragment<PollingStationViewModel>
                     }
                 })
         }
-        viewModel.selectedPollingStation().observe(this, Observer {
+        viewModel.selectedPollingStation().observe(viewLifecycleOwner, Observer {
             setSelection(it)
         })
         setContinueButton()
@@ -100,7 +100,7 @@ class PollingStationDetailsFragment : ViewModelFragment<PollingStationViewModel>
     private fun showDatePicker(dateTitleId: Int, timeTitleId: Int, listener: DateTimeListener) {
         val now = Calendar.getInstance()
         val datePickerDialog = DatePickerDialog(
-            activity!!,
+            requireActivity(),
             DatePickerDialog.OnDateSetListener { _, year, month, day ->
                 showTimePicker(timeTitleId, year, month, day, listener)
             }, now.get(Calendar.YEAR), now.get(Calendar.MONTH), now.get(Calendar.DAY_OF_MONTH)

app/src/main/java/ro/code4/monitorizarevot/ui/section/selection/PollingStationSelectionFragment.kt

@@ -47,7 +47,7 @@ class PollingStationSelectionFragment : ViewModelFragment<PollingStationSelectio
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
         countySpinnerAdapter =
-            ArrayAdapter(activity!!, R.layout.item_spinner, mutableListOf())
+            ArrayAdapter(requireActivity(), R.layout.item_spinner, mutableListOf())
         countySpinnerAdapter.setDropDownViewResource(R.layout.support_simple_spinner_dropdown_item)
     }