Skip to content

Commit b43ed7d

Browse files
committed
remove printer
1 parent 22e9e6f commit b43ed7d

File tree

7 files changed

+15
-69
lines changed

7 files changed

+15
-69
lines changed

pom.xml

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -31,18 +31,6 @@
3131
<artifactId>mockito-all</artifactId>
3232
<version>1.9.5</version>
3333
</dependency>
34-
<dependency>
35-
<groupId>org.powermock</groupId>
36-
<artifactId>powermock-module-junit4</artifactId>
37-
<version>1.5.2</version>
38-
<scope>test</scope>
39-
</dependency>
40-
<dependency>
41-
<groupId>org.powermock</groupId>
42-
<artifactId>powermock-api-mockito</artifactId>
43-
<version>1.5.2</version>
44-
<scope>test</scope>
45-
</dependency>
4634
</dependencies>
4735

4836

src/main/java/helloworld/behavioral/Printer.java

Lines changed: 0 additions & 22 deletions
This file was deleted.

src/main/java/helloworld/behavioral/command/HelloWorldPrintCommand.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
package helloworld.behavioral.command;
22

3-
import helloworld.behavioral.Printer;
3+
import java.io.PrintStream;
44

55
/**
66
* @author yihua.huang@dianping.com
77
*/
88
public class HelloWorldPrintCommand implements Command {
99

10-
private Printer printer = Printer.instance();
10+
private PrintStream printer = System.out;
1111

12-
public void setPrinter(Printer printer) {
12+
public void setPrinter(PrintStream printer) {
1313
this.printer = printer;
1414
}
1515

src/main/java/helloworld/behavioral/interpreter/HelloWorldInterpreter.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package helloworld.behavioral.interpreter;
22

3-
import helloworld.behavioral.Printer;
43
import org.apache.commons.lang3.StringUtils;
54

5+
import java.io.PrintStream;
66
import java.util.HashMap;
77
import java.util.Map;
88

@@ -41,9 +41,9 @@ public void registerFunction(String name, Function function) {
4141

4242
static class PrintlnFunction implements Function {
4343

44-
private Printer printer = Printer.instance();
44+
private PrintStream printer = System.out;
4545

46-
void setPrinter(Printer printer) {
46+
void setPrinter(PrintStream printer) {
4747
this.printer = printer;
4848
}
4949

src/test/java/helloworld/behavioral/PrinterTest.java

Lines changed: 0 additions & 25 deletions
This file was deleted.

src/test/java/helloworld/behavioral/command/HelloWorldPrintCommandTest.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
package helloworld.behavioral.command;
22

3-
import helloworld.behavioral.Printer;
3+
import com.sun.org.apache.xml.internal.serialize.Printer;
44
import org.junit.Test;
5+
6+
import java.io.PrintStream;
7+
58
import static org.mockito.Mockito.*;
69

710
/**
@@ -12,7 +15,7 @@ public class HelloWorldPrintCommandTest {
1215
@Test
1316
public void testHelloWorldPrintCommand(){
1417
HelloWorldPrintCommand helloWorldPrintCommand = new HelloWorldPrintCommand();
15-
Printer mockPrinter = mock(Printer.class);
18+
PrintStream mockPrinter = mock(PrintStream.class);
1619
helloWorldPrintCommand.setPrinter(mockPrinter);
1720
helloWorldPrintCommand.execute();
1821
verify(mockPrinter,times(1)).println("Hello Command!");

src/test/java/helloworld/behavioral/interpreter/HelloWorldInterpreterTest.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
package helloworld.behavioral.interpreter;
22

3-
import helloworld.behavioral.Printer;
43
import org.junit.Test;
4+
5+
import java.io.PrintStream;
6+
57
import static org.mockito.Mockito.*;
68

79
/**
@@ -12,7 +14,7 @@ public class HelloWorldInterpreterTest {
1214
@Test
1315
public void testHelloWorldInterpreter(){
1416
HelloWorldInterpreter helloWorldInterpreter = new HelloWorldInterpreter();
15-
Printer mockPrinter = mock(Printer.class);
17+
PrintStream mockPrinter = mock(PrintStream.class);
1618
HelloWorldInterpreter.PrintlnFunction printlnFunction = new HelloWorldInterpreter.PrintlnFunction();
1719
printlnFunction.setPrinter(mockPrinter);
1820
helloWorldInterpreter.registerFunction("println",printlnFunction);

0 commit comments

Comments
 (0)