Skip to content

Commit dcc30de

Browse files
pull[bot]pull[bot]
committed
[Fiber] Log Effect and Render Times in Offscreen Commit Phase (facebook#31788)
In facebook#30967 and facebook#30983 I added logging of the just rendered components and the effects. However this didn't consider the special Offscreen passes. So this adds the same thing to those passes. Log component effect timings for disconnected/reconnected offscreen subtrees. This includes initial mount of a Suspense boundary. Log component render timings for reconnected and already offscreen offscreen subtrees. DiffTrain build for [6a4b46c](facebook@6a4b46c)
1 parent 21e5027 commit dcc30de

34 files changed

+920
-920
lines changed

‎compiled/facebook-www/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
facec3ee71fff8b23f1e91005fce730cc96e4021
1+
6a4b46cd70d2672bc4be59dcb5b8dede22ed0cef

‎compiled/facebook-www/REVISION_TRANSFORMS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
facec3ee71fff8b23f1e91005fce730cc96e4021
1+
6a4b46cd70d2672bc4be59dcb5b8dede22ed0cef

‎compiled/facebook-www/React-dev.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1942,7 +1942,7 @@ __DEV__ &&
19421942
exports.useTransition = function () {
19431943
return resolveDispatcher().useTransition();
19441944
};
1945-
exports.version = "19.1.0-www-classic-facec3ee-20241217";
1945+
exports.version = "19.1.0-www-classic-6a4b46cd-20241217";
19461946
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
19471947
"function" ===
19481948
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/React-dev.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1942,7 +1942,7 @@ __DEV__ &&
19421942
exports.useTransition = function () {
19431943
return resolveDispatcher().useTransition();
19441944
};
1945-
exports.version = "19.1.0-www-modern-facec3ee-20241217";
1945+
exports.version = "19.1.0-www-modern-6a4b46cd-20241217";
19461946
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
19471947
"function" ===
19481948
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/React-prod.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -630,4 +630,4 @@ exports.useSyncExternalStore = function (
630630
exports.useTransition = function () {
631631
return ReactSharedInternals.H.useTransition();
632632
};
633-
exports.version = "19.1.0-www-classic-facec3ee-20241217";
633+
exports.version = "19.1.0-www-classic-6a4b46cd-20241217";

‎compiled/facebook-www/React-prod.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -630,4 +630,4 @@ exports.useSyncExternalStore = function (
630630
exports.useTransition = function () {
631631
return ReactSharedInternals.H.useTransition();
632632
};
633-
exports.version = "19.1.0-www-modern-facec3ee-20241217";
633+
exports.version = "19.1.0-www-modern-6a4b46cd-20241217";

‎compiled/facebook-www/React-profiling.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -634,7 +634,7 @@ exports.useSyncExternalStore = function (
634634
exports.useTransition = function () {
635635
return ReactSharedInternals.H.useTransition();
636636
};
637-
exports.version = "19.1.0-www-classic-facec3ee-20241217";
637+
exports.version = "19.1.0-www-classic-6a4b46cd-20241217";
638638
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
639639
"function" ===
640640
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/React-profiling.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -634,7 +634,7 @@ exports.useSyncExternalStore = function (
634634
exports.useTransition = function () {
635635
return ReactSharedInternals.H.useTransition();
636636
};
637-
exports.version = "19.1.0-www-modern-facec3ee-20241217";
637+
exports.version = "19.1.0-www-modern-6a4b46cd-20241217";
638638
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
639639
"function" ===
640640
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/ReactART-dev.classic.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13847,7 +13847,7 @@ __DEV__ &&
1384713847
shouldDoubleInvokePassiveEffects && disconnectPassiveEffect(fiber),
1384813848
reappearLayoutEffects(root, fiber.alternate, fiber, !1),
1384913849
shouldDoubleInvokePassiveEffects &&
13850-
reconnectPassiveEffects(root, fiber, 0, null, !1);
13850+
reconnectPassiveEffects(root, fiber, 0, null, !1, 0);
1385113851
} finally {
1385213852
setIsStrictModeForDevtools(!1);
1385313853
}
@@ -16898,10 +16898,10 @@ __DEV__ &&
1689816898
(function () {
1689916899
var internals = {
1690016900
bundleType: 1,
16901-
version: "19.1.0-www-classic-facec3ee-20241217",
16901+
version: "19.1.0-www-classic-6a4b46cd-20241217",
1690216902
rendererPackageName: "react-art",
1690316903
currentDispatcherRef: ReactSharedInternals,
16904-
reconcilerVersion: "19.1.0-www-classic-facec3ee-20241217"
16904+
reconcilerVersion: "19.1.0-www-classic-6a4b46cd-20241217"
1690516905
};
1690616906
internals.overrideHookState = overrideHookState;
1690716907
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -16935,7 +16935,7 @@ __DEV__ &&
1693516935
exports.Shape = Shape;
1693616936
exports.Surface = Surface;
1693716937
exports.Text = Text;
16938-
exports.version = "19.1.0-www-classic-facec3ee-20241217";
16938+
exports.version = "19.1.0-www-classic-6a4b46cd-20241217";
1693916939
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1694016940
"function" ===
1694116941
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/ReactART-dev.modern.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13647,7 +13647,7 @@ __DEV__ &&
1364713647
shouldDoubleInvokePassiveEffects && disconnectPassiveEffect(fiber),
1364813648
reappearLayoutEffects(root, fiber.alternate, fiber, !1),
1364913649
shouldDoubleInvokePassiveEffects &&
13650-
reconnectPassiveEffects(root, fiber, 0, null, !1);
13650+
reconnectPassiveEffects(root, fiber, 0, null, !1, 0);
1365113651
} finally {
1365213652
setIsStrictModeForDevtools(!1);
1365313653
}
@@ -16661,10 +16661,10 @@ __DEV__ &&
1666116661
(function () {
1666216662
var internals = {
1666316663
bundleType: 1,
16664-
version: "19.1.0-www-modern-facec3ee-20241217",
16664+
version: "19.1.0-www-modern-6a4b46cd-20241217",
1666516665
rendererPackageName: "react-art",
1666616666
currentDispatcherRef: ReactSharedInternals,
16667-
reconcilerVersion: "19.1.0-www-modern-facec3ee-20241217"
16667+
reconcilerVersion: "19.1.0-www-modern-6a4b46cd-20241217"
1666816668
};
1666916669
internals.overrideHookState = overrideHookState;
1667016670
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -16698,7 +16698,7 @@ __DEV__ &&
1669816698
exports.Shape = Shape;
1669916699
exports.Surface = Surface;
1670016700
exports.Text = Text;
16701-
exports.version = "19.1.0-www-modern-facec3ee-20241217";
16701+
exports.version = "19.1.0-www-modern-6a4b46cd-20241217";
1670216702
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1670316703
"function" ===
1670416704
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/ReactART-prod.classic.js

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10755,24 +10755,24 @@ var slice = Array.prototype.slice,
1075510755
};
1075610756
return Text;
1075710757
})(React.Component);
10758-
var internals$jscomp$inline_1493 = {
10758+
var internals$jscomp$inline_1495 = {
1075910759
bundleType: 0,
10760-
version: "19.1.0-www-classic-facec3ee-20241217",
10760+
version: "19.1.0-www-classic-6a4b46cd-20241217",
1076110761
rendererPackageName: "react-art",
1076210762
currentDispatcherRef: ReactSharedInternals,
10763-
reconcilerVersion: "19.1.0-www-classic-facec3ee-20241217"
10763+
reconcilerVersion: "19.1.0-www-classic-6a4b46cd-20241217"
1076410764
};
1076510765
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
10766-
var hook$jscomp$inline_1494 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
10766+
var hook$jscomp$inline_1496 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
1076710767
if (
10768-
!hook$jscomp$inline_1494.isDisabled &&
10769-
hook$jscomp$inline_1494.supportsFiber
10768+
!hook$jscomp$inline_1496.isDisabled &&
10769+
hook$jscomp$inline_1496.supportsFiber
1077010770
)
1077110771
try {
10772-
(rendererID = hook$jscomp$inline_1494.inject(
10773-
internals$jscomp$inline_1493
10772+
(rendererID = hook$jscomp$inline_1496.inject(
10773+
internals$jscomp$inline_1495
1077410774
)),
10775-
(injectedHook = hook$jscomp$inline_1494);
10775+
(injectedHook = hook$jscomp$inline_1496);
1077610776
} catch (err) {}
1077710777
}
1077810778
var Path = Mode$1.Path;
@@ -10786,4 +10786,4 @@ exports.RadialGradient = RadialGradient;
1078610786
exports.Shape = TYPES.SHAPE;
1078710787
exports.Surface = Surface;
1078810788
exports.Text = Text;
10789-
exports.version = "19.1.0-www-classic-facec3ee-20241217";
10789+
exports.version = "19.1.0-www-classic-6a4b46cd-20241217";

‎compiled/facebook-www/ReactART-prod.modern.js

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10471,24 +10471,24 @@ var slice = Array.prototype.slice,
1047110471
};
1047210472
return Text;
1047310473
})(React.Component);
10474-
var internals$jscomp$inline_1472 = {
10474+
var internals$jscomp$inline_1474 = {
1047510475
bundleType: 0,
10476-
version: "19.1.0-www-modern-facec3ee-20241217",
10476+
version: "19.1.0-www-modern-6a4b46cd-20241217",
1047710477
rendererPackageName: "react-art",
1047810478
currentDispatcherRef: ReactSharedInternals,
10479-
reconcilerVersion: "19.1.0-www-modern-facec3ee-20241217"
10479+
reconcilerVersion: "19.1.0-www-modern-6a4b46cd-20241217"
1048010480
};
1048110481
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
10482-
var hook$jscomp$inline_1473 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
10482+
var hook$jscomp$inline_1475 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
1048310483
if (
10484-
!hook$jscomp$inline_1473.isDisabled &&
10485-
hook$jscomp$inline_1473.supportsFiber
10484+
!hook$jscomp$inline_1475.isDisabled &&
10485+
hook$jscomp$inline_1475.supportsFiber
1048610486
)
1048710487
try {
10488-
(rendererID = hook$jscomp$inline_1473.inject(
10489-
internals$jscomp$inline_1472
10488+
(rendererID = hook$jscomp$inline_1475.inject(
10489+
internals$jscomp$inline_1474
1049010490
)),
10491-
(injectedHook = hook$jscomp$inline_1473);
10491+
(injectedHook = hook$jscomp$inline_1475);
1049210492
} catch (err) {}
1049310493
}
1049410494
var Path = Mode$1.Path;
@@ -10502,4 +10502,4 @@ exports.RadialGradient = RadialGradient;
1050210502
exports.Shape = TYPES.SHAPE;
1050310503
exports.Surface = Surface;
1050410504
exports.Text = Text;
10505-
exports.version = "19.1.0-www-modern-facec3ee-20241217";
10505+
exports.version = "19.1.0-www-modern-6a4b46cd-20241217";

0 commit comments

Comments
 (0)