Skip to content

Commit daa1e2d

Browse files
pull[bot]pull[bot]
committed
Fix incorrect use of NoLanes in executionContext check (facebook#33170)
## Summary This PR fixes a likely incorrect condition in the `scheduleUpdateOnFiber` function inside `ReactFiberWorkLoop.js`. Previously, the code checked: ```js (executionContext & RenderContext) !== NoLanes ```` However, `NoLanes` is part of the lane priority system, not the execution context flags. The intent here seems to be to detect whether the current execution context includes `RenderContext`, which should be compared against `NoContext`, not `NoLanes`. This fix replaces `NoLanes` with `NoContext` for semantic correctness and consistency with other checks throughout the codebase. **Fixes [[facebook#33169](https://github.com/facebook/react/issues/33169)](https://github.com/facebook/react/issues/33169)** --- ## How did you test this change? I ran the following commands to validate correctness and ensure nothing was broken: * `yarn lint` * `yarn linc` * `yarn test` * `yarn test --prod` * `yarn flow` * `yarn prettier` All checks passed. Since this is a minor internal logic fix and doesn't change public behavior or APIs, no additional tests are necessary at this time. DiffTrain build for [bfaeb4a](facebook@bfaeb4a)
1 parent 196955e commit daa1e2d

24 files changed

+92
-92
lines changed

‎compiled-rn/VERSION_NATIVE_FB‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
19.2.0-native-fb-3e9db65f-20250522
1+
19.2.0-native-fb-bfaeb4a4-20250522

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-dev.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<dac9ca83edabc58857a3d190cb9f2a44>>
10+
* @generated SignedSource<<6a7e54840da99104aecbe3dc774dad02>>
1111
*/
1212

1313
"use strict";
@@ -404,5 +404,5 @@ __DEV__ &&
404404
exports.useFormStatus = function () {
405405
return resolveDispatcher().useHostTransitionStatus();
406406
};
407-
exports.version = "19.2.0-native-fb-3e9db65f-20250522";
407+
exports.version = "19.2.0-native-fb-bfaeb4a4-20250522";
408408
})();

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-prod.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<53f1e1206c5f002b04b2c1c68ddbdd8b>>
10+
* @generated SignedSource<<a276b11779b64c33be52914eabbdf4ca>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.2.0-native-fb-3e9db65f-20250522";
206+
exports.version = "19.2.0-native-fb-bfaeb4a4-20250522";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-profiling.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<53f1e1206c5f002b04b2c1c68ddbdd8b>>
10+
* @generated SignedSource<<a276b11779b64c33be52914eabbdf4ca>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.2.0-native-fb-3e9db65f-20250522";
206+
exports.version = "19.2.0-native-fb-bfaeb4a4-20250522";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-dev.js‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<9f2fc558c75e1064b5c2fc83786e0864>>
10+
* @generated SignedSource<<fdc537342a001c53a8536ffdc903fb2b>>
1111
*/
1212

1313
/*
@@ -15664,7 +15664,7 @@ __DEV__ &&
1566415664
);
1566515665
markRootUpdated$1(root, lane);
1566615666
if (
15667-
0 !== (executionContext & RenderContext) &&
15667+
(executionContext & RenderContext) !== NoContext &&
1566815668
root === workInProgressRoot
1566915669
) {
1567015670
if (isRendering)
@@ -27026,11 +27026,11 @@ __DEV__ &&
2702627026
};
2702727027
(function () {
2702827028
var isomorphicReactPackageVersion = React.version;
27029-
if ("19.2.0-native-fb-3e9db65f-20250522" !== isomorphicReactPackageVersion)
27029+
if ("19.2.0-native-fb-bfaeb4a4-20250522" !== isomorphicReactPackageVersion)
2703027030
throw Error(
2703127031
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
2703227032
(isomorphicReactPackageVersion +
27033-
"\n - react-dom: 19.2.0-native-fb-3e9db65f-20250522\nLearn more: https://react.dev/warnings/version-mismatch")
27033+
"\n - react-dom: 19.2.0-native-fb-bfaeb4a4-20250522\nLearn more: https://react.dev/warnings/version-mismatch")
2703427034
);
2703527035
})();
2703627036
("function" === typeof Map &&
@@ -27067,10 +27067,10 @@ __DEV__ &&
2706727067
!(function () {
2706827068
var internals = {
2706927069
bundleType: 1,
27070-
version: "19.2.0-native-fb-3e9db65f-20250522",
27070+
version: "19.2.0-native-fb-bfaeb4a4-20250522",
2707127071
rendererPackageName: "react-dom",
2707227072
currentDispatcherRef: ReactSharedInternals,
27073-
reconcilerVersion: "19.2.0-native-fb-3e9db65f-20250522"
27073+
reconcilerVersion: "19.2.0-native-fb-bfaeb4a4-20250522"
2707427074
};
2707527075
internals.overrideHookState = overrideHookState;
2707627076
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -27208,5 +27208,5 @@ __DEV__ &&
2720827208
listenToAllSupportedEvents(container);
2720927209
return new ReactDOMHydrationRoot(initialChildren);
2721027210
};
27211-
exports.version = "19.2.0-native-fb-3e9db65f-20250522";
27211+
exports.version = "19.2.0-native-fb-bfaeb4a4-20250522";
2721227212
})();

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-prod.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<37871e0f70b5f908f012f6e072ed5370>>
10+
* @generated SignedSource<<5ba1b6d58a5622c6473b7acb9d81f7f2>>
1111
*/
1212

1313
/*
@@ -17094,14 +17094,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1709417094
};
1709517095
var isomorphicReactPackageVersion$jscomp$inline_2017 = React.version;
1709617096
if (
17097-
"19.2.0-native-fb-3e9db65f-20250522" !==
17097+
"19.2.0-native-fb-bfaeb4a4-20250522" !==
1709817098
isomorphicReactPackageVersion$jscomp$inline_2017
1709917099
)
1710017100
throw Error(
1710117101
formatProdErrorMessage(
1710217102
527,
1710317103
isomorphicReactPackageVersion$jscomp$inline_2017,
17104-
"19.2.0-native-fb-3e9db65f-20250522"
17104+
"19.2.0-native-fb-bfaeb4a4-20250522"
1710517105
)
1710617106
);
1710717107
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -17123,10 +17123,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1712317123
};
1712417124
var internals$jscomp$inline_2536 = {
1712517125
bundleType: 0,
17126-
version: "19.2.0-native-fb-3e9db65f-20250522",
17126+
version: "19.2.0-native-fb-bfaeb4a4-20250522",
1712717127
rendererPackageName: "react-dom",
1712817128
currentDispatcherRef: ReactSharedInternals,
17129-
reconcilerVersion: "19.2.0-native-fb-3e9db65f-20250522"
17129+
reconcilerVersion: "19.2.0-native-fb-bfaeb4a4-20250522"
1713017130
};
1713117131
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1713217132
var hook$jscomp$inline_2537 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -17224,4 +17224,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1722417224
listenToAllSupportedEvents(container);
1722517225
return new ReactDOMHydrationRoot(initialChildren);
1722617226
};
17227-
exports.version = "19.2.0-native-fb-3e9db65f-20250522";
17227+
exports.version = "19.2.0-native-fb-bfaeb4a4-20250522";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-profiling.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<ad0ae4d2760514dc956302aee6724a28>>
10+
* @generated SignedSource<<839aebb5962a5c0736a3655361f5ec18>>
1111
*/
1212

1313
/*
@@ -17804,14 +17804,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1780417804
};
1780517805
var isomorphicReactPackageVersion$jscomp$inline_2120 = React.version;
1780617806
if (
17807-
"19.2.0-native-fb-3e9db65f-20250522" !==
17807+
"19.2.0-native-fb-bfaeb4a4-20250522" !==
1780817808
isomorphicReactPackageVersion$jscomp$inline_2120
1780917809
)
1781017810
throw Error(
1781117811
formatProdErrorMessage(
1781217812
527,
1781317813
isomorphicReactPackageVersion$jscomp$inline_2120,
17814-
"19.2.0-native-fb-3e9db65f-20250522"
17814+
"19.2.0-native-fb-bfaeb4a4-20250522"
1781517815
)
1781617816
);
1781717817
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -17833,10 +17833,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1783317833
};
1783417834
var internals$jscomp$inline_2127 = {
1783517835
bundleType: 0,
17836-
version: "19.2.0-native-fb-3e9db65f-20250522",
17836+
version: "19.2.0-native-fb-bfaeb4a4-20250522",
1783717837
rendererPackageName: "react-dom",
1783817838
currentDispatcherRef: ReactSharedInternals,
17839-
reconcilerVersion: "19.2.0-native-fb-3e9db65f-20250522",
17839+
reconcilerVersion: "19.2.0-native-fb-bfaeb4a4-20250522",
1784017840
getLaneLabelMap: function () {
1784117841
for (
1784217842
var map = new Map(), lane = 1, index$313 = 0;
@@ -17949,4 +17949,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1794917949
listenToAllSupportedEvents(container);
1795017950
return new ReactDOMHydrationRoot(initialChildren);
1795117951
};
17952-
exports.version = "19.2.0-native-fb-3e9db65f-20250522";
17952+
exports.version = "19.2.0-native-fb-bfaeb4a4-20250522";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-dev.js‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<c1dfa310f4b5e20d998fba363b14b653>>
10+
* @generated SignedSource<<a6c16f656f28616f5e97803923c747eb>>
1111
*/
1212

1313
/*
@@ -15672,7 +15672,7 @@ __DEV__ &&
1567215672
);
1567315673
markRootUpdated$1(root, lane);
1567415674
if (
15675-
0 !== (executionContext & RenderContext) &&
15675+
(executionContext & RenderContext) !== NoContext &&
1567615676
root === workInProgressRoot
1567715677
) {
1567815678
if (isRendering)
@@ -27082,11 +27082,11 @@ __DEV__ &&
2708227082
};
2708327083
(function () {
2708427084
var isomorphicReactPackageVersion = React.version;
27085-
if ("19.2.0-native-fb-3e9db65f-20250522" !== isomorphicReactPackageVersion)
27085+
if ("19.2.0-native-fb-bfaeb4a4-20250522" !== isomorphicReactPackageVersion)
2708627086
throw Error(
2708727087
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
2708827088
(isomorphicReactPackageVersion +
27089-
"\n - react-dom: 19.2.0-native-fb-3e9db65f-20250522\nLearn more: https://react.dev/warnings/version-mismatch")
27089+
"\n - react-dom: 19.2.0-native-fb-bfaeb4a4-20250522\nLearn more: https://react.dev/warnings/version-mismatch")
2709027090
);
2709127091
})();
2709227092
("function" === typeof Map &&
@@ -27123,10 +27123,10 @@ __DEV__ &&
2712327123
!(function () {
2712427124
var internals = {
2712527125
bundleType: 1,
27126-
version: "19.2.0-native-fb-3e9db65f-20250522",
27126+
version: "19.2.0-native-fb-bfaeb4a4-20250522",
2712727127
rendererPackageName: "react-dom",
2712827128
currentDispatcherRef: ReactSharedInternals,
27129-
reconcilerVersion: "19.2.0-native-fb-3e9db65f-20250522"
27129+
reconcilerVersion: "19.2.0-native-fb-bfaeb4a4-20250522"
2713027130
};
2713127131
internals.overrideHookState = overrideHookState;
2713227132
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -27580,7 +27580,7 @@ __DEV__ &&
2758027580
exports.useFormStatus = function () {
2758127581
return resolveDispatcher().useHostTransitionStatus();
2758227582
};
27583-
exports.version = "19.2.0-native-fb-3e9db65f-20250522";
27583+
exports.version = "19.2.0-native-fb-bfaeb4a4-20250522";
2758427584
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
2758527585
"function" ===
2758627586
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-prod.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<4a60d0004d11f5abd3a988d297db09bf>>
10+
* @generated SignedSource<<b10e021f88454a685f1724e243f04485>>
1111
*/
1212

1313
/*
@@ -17105,14 +17105,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1710517105
};
1710617106
var isomorphicReactPackageVersion$jscomp$inline_2018 = React.version;
1710717107
if (
17108-
"19.2.0-native-fb-3e9db65f-20250522" !==
17108+
"19.2.0-native-fb-bfaeb4a4-20250522" !==
1710917109
isomorphicReactPackageVersion$jscomp$inline_2018
1711017110
)
1711117111
throw Error(
1711217112
formatProdErrorMessage(
1711317113
527,
1711417114
isomorphicReactPackageVersion$jscomp$inline_2018,
17115-
"19.2.0-native-fb-3e9db65f-20250522"
17115+
"19.2.0-native-fb-bfaeb4a4-20250522"
1711617116
)
1711717117
);
1711817118
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -17134,10 +17134,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1713417134
};
1713517135
var internals$jscomp$inline_2539 = {
1713617136
bundleType: 0,
17137-
version: "19.2.0-native-fb-3e9db65f-20250522",
17137+
version: "19.2.0-native-fb-bfaeb4a4-20250522",
1713817138
rendererPackageName: "react-dom",
1713917139
currentDispatcherRef: ReactSharedInternals,
17140-
reconcilerVersion: "19.2.0-native-fb-3e9db65f-20250522"
17140+
reconcilerVersion: "19.2.0-native-fb-bfaeb4a4-20250522"
1714117141
};
1714217142
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1714317143
var hook$jscomp$inline_2540 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -17388,4 +17388,4 @@ exports.useFormState = function (action, initialState, permalink) {
1738817388
exports.useFormStatus = function () {
1738917389
return ReactSharedInternals.H.useHostTransitionStatus();
1739017390
};
17391-
exports.version = "19.2.0-native-fb-3e9db65f-20250522";
17391+
exports.version = "19.2.0-native-fb-bfaeb4a4-20250522";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-profiling.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<5eba7e429cb8d9b3ade50fd9cdc7f785>>
10+
* @generated SignedSource<<0f1a2bae32b228a438b8ee79fb9901cf>>
1111
*/
1212

1313
/*
@@ -17819,14 +17819,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1781917819
};
1782017820
var isomorphicReactPackageVersion$jscomp$inline_2121 = React.version;
1782117821
if (
17822-
"19.2.0-native-fb-3e9db65f-20250522" !==
17822+
"19.2.0-native-fb-bfaeb4a4-20250522" !==
1782317823
isomorphicReactPackageVersion$jscomp$inline_2121
1782417824
)
1782517825
throw Error(
1782617826
formatProdErrorMessage(
1782717827
527,
1782817828
isomorphicReactPackageVersion$jscomp$inline_2121,
17829-
"19.2.0-native-fb-3e9db65f-20250522"
17829+
"19.2.0-native-fb-bfaeb4a4-20250522"
1783017830
)
1783117831
);
1783217832
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -17848,10 +17848,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1784817848
};
1784917849
var internals$jscomp$inline_2128 = {
1785017850
bundleType: 0,
17851-
version: "19.2.0-native-fb-3e9db65f-20250522",
17851+
version: "19.2.0-native-fb-bfaeb4a4-20250522",
1785217852
rendererPackageName: "react-dom",
1785317853
currentDispatcherRef: ReactSharedInternals,
17854-
reconcilerVersion: "19.2.0-native-fb-3e9db65f-20250522",
17854+
reconcilerVersion: "19.2.0-native-fb-bfaeb4a4-20250522",
1785517855
getLaneLabelMap: function () {
1785617856
for (
1785717857
var map = new Map(), lane = 1, index$313 = 0;
@@ -18117,7 +18117,7 @@ exports.useFormState = function (action, initialState, permalink) {
1811718117
exports.useFormStatus = function () {
1811818118
return ReactSharedInternals.H.useHostTransitionStatus();
1811918119
};
18120-
exports.version = "19.2.0-native-fb-3e9db65f-20250522";
18120+
exports.version = "19.2.0-native-fb-bfaeb4a4-20250522";
1812118121
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1812218122
"function" ===
1812318123
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)