Skip to content

Commit 1dc9383

Browse files
pull[bot]pull[bot]
committed
Revert "enableViewTransition in www" (facebook#33362)
We need to do some more testing here. Reverts facebook#33357 DiffTrain build for [283f87f](facebook@283f87f)
1 parent 1601686 commit 1dc9383

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

42 files changed

+6143
-6680
lines changed

‎compiled/facebook-www/JSXDEVRuntime-dev.classic.js

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ __DEV__ &&
3434
case REACT_ACTIVITY_TYPE:
3535
return "Activity";
3636
case REACT_VIEW_TRANSITION_TYPE:
37-
return "ViewTransition";
37+
if (enableViewTransition) return "ViewTransition";
3838
case REACT_TRACING_MARKER_TYPE:
3939
if (enableTransitionTracing) return "TracingMarker";
4040
}
@@ -308,12 +308,13 @@ __DEV__ &&
308308
disableDefaultPropsExceptForClasses =
309309
dynamicFeatureFlags.disableDefaultPropsExceptForClasses,
310310
enableRenderableContext = dynamicFeatureFlags.enableRenderableContext,
311-
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing;
312-
dynamicFeatureFlags = dynamicFeatureFlags.renameElementSymbol;
313-
var REACT_LEGACY_ELEMENT_TYPE = Symbol.for("react.element"),
314-
REACT_ELEMENT_TYPE = dynamicFeatureFlags
311+
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
312+
renameElementSymbol = dynamicFeatureFlags.renameElementSymbol,
313+
enableViewTransition = dynamicFeatureFlags.enableViewTransition;
314+
dynamicFeatureFlags = Symbol.for("react.element");
315+
var REACT_ELEMENT_TYPE = renameElementSymbol
315316
? Symbol.for("react.transitional.element")
316-
: REACT_LEGACY_ELEMENT_TYPE,
317+
: dynamicFeatureFlags,
317318
REACT_PORTAL_TYPE = Symbol.for("react.portal"),
318319
REACT_FRAGMENT_TYPE = Symbol.for("react.fragment"),
319320
REACT_STRICT_MODE_TYPE = Symbol.for("react.strict_mode"),

‎compiled/facebook-www/JSXDEVRuntime-dev.modern.js

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ __DEV__ &&
3434
case REACT_ACTIVITY_TYPE:
3535
return "Activity";
3636
case REACT_VIEW_TRANSITION_TYPE:
37-
return "ViewTransition";
37+
if (enableViewTransition) return "ViewTransition";
3838
case REACT_TRACING_MARKER_TYPE:
3939
if (enableTransitionTracing) return "TracingMarker";
4040
}
@@ -308,12 +308,13 @@ __DEV__ &&
308308
disableDefaultPropsExceptForClasses =
309309
dynamicFeatureFlags.disableDefaultPropsExceptForClasses,
310310
enableRenderableContext = dynamicFeatureFlags.enableRenderableContext,
311-
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing;
312-
dynamicFeatureFlags = dynamicFeatureFlags.renameElementSymbol;
313-
var REACT_LEGACY_ELEMENT_TYPE = Symbol.for("react.element"),
314-
REACT_ELEMENT_TYPE = dynamicFeatureFlags
311+
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
312+
renameElementSymbol = dynamicFeatureFlags.renameElementSymbol,
313+
enableViewTransition = dynamicFeatureFlags.enableViewTransition;
314+
dynamicFeatureFlags = Symbol.for("react.element");
315+
var REACT_ELEMENT_TYPE = renameElementSymbol
315316
? Symbol.for("react.transitional.element")
316-
: REACT_LEGACY_ELEMENT_TYPE,
317+
: dynamicFeatureFlags,
317318
REACT_PORTAL_TYPE = Symbol.for("react.portal"),
318319
REACT_FRAGMENT_TYPE = Symbol.for("react.fragment"),
319320
REACT_STRICT_MODE_TYPE = Symbol.for("react.strict_mode"),

‎compiled/facebook-www/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
f9ae0a4c2edc9ad93507b550f2aeb60119955336
1+
283f87f083f285c060582e1096cebed794d4b748

‎compiled/facebook-www/REVISION_TRANSFORMS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
f9ae0a4c2edc9ad93507b550f2aeb60119955336
1+
283f87f083f285c060582e1096cebed794d4b748

‎compiled/facebook-www/React-dev.classic.js

Lines changed: 30 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ __DEV__ &&
108108
case REACT_ACTIVITY_TYPE:
109109
return "Activity";
110110
case REACT_VIEW_TRANSITION_TYPE:
111-
return "ViewTransition";
111+
if (enableViewTransition) return "ViewTransition";
112112
case REACT_TRACING_MARKER_TYPE:
113113
if (enableTransitionTracing) return "TracingMarker";
114114
}
@@ -604,8 +604,9 @@ __DEV__ &&
604604
function startTransition(scope, options) {
605605
var prevTransition = ReactSharedInternals.T,
606606
currentTransition = {};
607-
currentTransition.types =
608-
null !== prevTransition ? prevTransition.types : null;
607+
enableViewTransition &&
608+
(currentTransition.types =
609+
null !== prevTransition ? prevTransition.types : null);
609610
enableTransitionTracing &&
610611
((currentTransition.name =
611612
void 0 !== options && void 0 !== options.name ? options.name : null),
@@ -646,18 +647,21 @@ __DEV__ &&
646647
}
647648
}
648649
function addTransitionType(type) {
649-
var transition = ReactSharedInternals.T;
650-
if (null !== transition) {
651-
var transitionTypes = transition.types;
652-
null === transitionTypes
653-
? (transition.types = [type])
654-
: -1 === transitionTypes.indexOf(type) && transitionTypes.push(type);
655-
} else
656-
0 === ReactSharedInternals.asyncTransitions &&
657-
console.error(
658-
"addTransitionType can only be called inside a `startTransition()` callback. It must be associated with a specific Transition."
659-
),
660-
startTransition(addTransitionType.bind(null, type));
650+
if (enableViewTransition) {
651+
var transition = ReactSharedInternals.T;
652+
if (null !== transition) {
653+
var transitionTypes = transition.types;
654+
null === transitionTypes
655+
? (transition.types = [type])
656+
: -1 === transitionTypes.indexOf(type) &&
657+
transitionTypes.push(type);
658+
} else
659+
0 === ReactSharedInternals.asyncTransitions &&
660+
console.error(
661+
"addTransitionType can only be called inside a `startTransition()` callback. It must be associated with a specific Transition."
662+
),
663+
startTransition(addTransitionType.bind(null, type));
664+
}
661665
}
662666
function enqueueTask(task) {
663667
if (null === enqueueTaskImpl)
@@ -750,12 +754,13 @@ __DEV__ &&
750754
disableDefaultPropsExceptForClasses =
751755
dynamicFeatureFlags.disableDefaultPropsExceptForClasses,
752756
enableRenderableContext = dynamicFeatureFlags.enableRenderableContext,
753-
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing;
754-
dynamicFeatureFlags = dynamicFeatureFlags.renameElementSymbol;
755-
var REACT_LEGACY_ELEMENT_TYPE = Symbol.for("react.element"),
756-
REACT_ELEMENT_TYPE = dynamicFeatureFlags
757+
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
758+
renameElementSymbol = dynamicFeatureFlags.renameElementSymbol,
759+
enableViewTransition = dynamicFeatureFlags.enableViewTransition;
760+
dynamicFeatureFlags = Symbol.for("react.element");
761+
var REACT_ELEMENT_TYPE = renameElementSymbol
757762
? Symbol.for("react.transitional.element")
758-
: REACT_LEGACY_ELEMENT_TYPE,
763+
: dynamicFeatureFlags,
759764
REACT_PORTAL_TYPE = Symbol.for("react.portal"),
760765
REACT_FRAGMENT_TYPE = Symbol.for("react.fragment"),
761766
REACT_STRICT_MODE_TYPE = Symbol.for("react.strict_mode"),
@@ -768,9 +773,9 @@ __DEV__ &&
768773
REACT_SUSPENSE_LIST_TYPE = Symbol.for("react.suspense_list"),
769774
REACT_MEMO_TYPE = Symbol.for("react.memo"),
770775
REACT_LAZY_TYPE = Symbol.for("react.lazy");
771-
dynamicFeatureFlags = Symbol.for("react.scope");
776+
renameElementSymbol = Symbol.for("react.scope");
772777
var REACT_ACTIVITY_TYPE = Symbol.for("react.activity");
773-
REACT_LEGACY_ELEMENT_TYPE = Symbol.for("react.legacy_hidden");
778+
dynamicFeatureFlags = Symbol.for("react.legacy_hidden");
774779
var REACT_TRACING_MARKER_TYPE = Symbol.for("react.tracing_marker"),
775780
REACT_VIEW_TRANSITION_TYPE = Symbol.for("react.view_transition"),
776781
MAYBE_ITERATOR_SYMBOL = Symbol.iterator,
@@ -1433,8 +1438,8 @@ __DEV__ &&
14331438
};
14341439
exports.startTransition = startTransition;
14351440
exports.unstable_Activity = REACT_ACTIVITY_TYPE;
1436-
exports.unstable_LegacyHidden = REACT_LEGACY_ELEMENT_TYPE;
1437-
exports.unstable_Scope = dynamicFeatureFlags;
1441+
exports.unstable_LegacyHidden = dynamicFeatureFlags;
1442+
exports.unstable_Scope = renameElementSymbol;
14381443
exports.unstable_SuspenseList = REACT_SUSPENSE_LIST_TYPE;
14391444
exports.unstable_TracingMarker = REACT_TRACING_MARKER_TYPE;
14401445
exports.unstable_ViewTransition = REACT_VIEW_TRANSITION_TYPE;
@@ -1532,7 +1537,7 @@ __DEV__ &&
15321537
exports.useTransition = function () {
15331538
return resolveDispatcher().useTransition();
15341539
};
1535-
exports.version = "19.2.0-www-classic-f9ae0a4c-20250527";
1540+
exports.version = "19.2.0-www-classic-283f87f0-20250527";
15361541
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
15371542
"function" ===
15381543
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/React-dev.modern.js

Lines changed: 30 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ __DEV__ &&
108108
case REACT_ACTIVITY_TYPE:
109109
return "Activity";
110110
case REACT_VIEW_TRANSITION_TYPE:
111-
return "ViewTransition";
111+
if (enableViewTransition) return "ViewTransition";
112112
case REACT_TRACING_MARKER_TYPE:
113113
if (enableTransitionTracing) return "TracingMarker";
114114
}
@@ -604,8 +604,9 @@ __DEV__ &&
604604
function startTransition(scope, options) {
605605
var prevTransition = ReactSharedInternals.T,
606606
currentTransition = {};
607-
currentTransition.types =
608-
null !== prevTransition ? prevTransition.types : null;
607+
enableViewTransition &&
608+
(currentTransition.types =
609+
null !== prevTransition ? prevTransition.types : null);
609610
enableTransitionTracing &&
610611
((currentTransition.name =
611612
void 0 !== options && void 0 !== options.name ? options.name : null),
@@ -646,18 +647,21 @@ __DEV__ &&
646647
}
647648
}
648649
function addTransitionType(type) {
649-
var transition = ReactSharedInternals.T;
650-
if (null !== transition) {
651-
var transitionTypes = transition.types;
652-
null === transitionTypes
653-
? (transition.types = [type])
654-
: -1 === transitionTypes.indexOf(type) && transitionTypes.push(type);
655-
} else
656-
0 === ReactSharedInternals.asyncTransitions &&
657-
console.error(
658-
"addTransitionType can only be called inside a `startTransition()` callback. It must be associated with a specific Transition."
659-
),
660-
startTransition(addTransitionType.bind(null, type));
650+
if (enableViewTransition) {
651+
var transition = ReactSharedInternals.T;
652+
if (null !== transition) {
653+
var transitionTypes = transition.types;
654+
null === transitionTypes
655+
? (transition.types = [type])
656+
: -1 === transitionTypes.indexOf(type) &&
657+
transitionTypes.push(type);
658+
} else
659+
0 === ReactSharedInternals.asyncTransitions &&
660+
console.error(
661+
"addTransitionType can only be called inside a `startTransition()` callback. It must be associated with a specific Transition."
662+
),
663+
startTransition(addTransitionType.bind(null, type));
664+
}
661665
}
662666
function enqueueTask(task) {
663667
if (null === enqueueTaskImpl)
@@ -750,12 +754,13 @@ __DEV__ &&
750754
disableDefaultPropsExceptForClasses =
751755
dynamicFeatureFlags.disableDefaultPropsExceptForClasses,
752756
enableRenderableContext = dynamicFeatureFlags.enableRenderableContext,
753-
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing;
754-
dynamicFeatureFlags = dynamicFeatureFlags.renameElementSymbol;
755-
var REACT_LEGACY_ELEMENT_TYPE = Symbol.for("react.element"),
756-
REACT_ELEMENT_TYPE = dynamicFeatureFlags
757+
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
758+
renameElementSymbol = dynamicFeatureFlags.renameElementSymbol,
759+
enableViewTransition = dynamicFeatureFlags.enableViewTransition;
760+
dynamicFeatureFlags = Symbol.for("react.element");
761+
var REACT_ELEMENT_TYPE = renameElementSymbol
757762
? Symbol.for("react.transitional.element")
758-
: REACT_LEGACY_ELEMENT_TYPE,
763+
: dynamicFeatureFlags,
759764
REACT_PORTAL_TYPE = Symbol.for("react.portal"),
760765
REACT_FRAGMENT_TYPE = Symbol.for("react.fragment"),
761766
REACT_STRICT_MODE_TYPE = Symbol.for("react.strict_mode"),
@@ -768,9 +773,9 @@ __DEV__ &&
768773
REACT_SUSPENSE_LIST_TYPE = Symbol.for("react.suspense_list"),
769774
REACT_MEMO_TYPE = Symbol.for("react.memo"),
770775
REACT_LAZY_TYPE = Symbol.for("react.lazy");
771-
dynamicFeatureFlags = Symbol.for("react.scope");
776+
renameElementSymbol = Symbol.for("react.scope");
772777
var REACT_ACTIVITY_TYPE = Symbol.for("react.activity");
773-
REACT_LEGACY_ELEMENT_TYPE = Symbol.for("react.legacy_hidden");
778+
dynamicFeatureFlags = Symbol.for("react.legacy_hidden");
774779
var REACT_TRACING_MARKER_TYPE = Symbol.for("react.tracing_marker"),
775780
REACT_VIEW_TRANSITION_TYPE = Symbol.for("react.view_transition"),
776781
MAYBE_ITERATOR_SYMBOL = Symbol.iterator,
@@ -1433,8 +1438,8 @@ __DEV__ &&
14331438
};
14341439
exports.startTransition = startTransition;
14351440
exports.unstable_Activity = REACT_ACTIVITY_TYPE;
1436-
exports.unstable_LegacyHidden = REACT_LEGACY_ELEMENT_TYPE;
1437-
exports.unstable_Scope = dynamicFeatureFlags;
1441+
exports.unstable_LegacyHidden = dynamicFeatureFlags;
1442+
exports.unstable_Scope = renameElementSymbol;
14381443
exports.unstable_SuspenseList = REACT_SUSPENSE_LIST_TYPE;
14391444
exports.unstable_TracingMarker = REACT_TRACING_MARKER_TYPE;
14401445
exports.unstable_ViewTransition = REACT_VIEW_TRANSITION_TYPE;
@@ -1532,7 +1537,7 @@ __DEV__ &&
15321537
exports.useTransition = function () {
15331538
return resolveDispatcher().useTransition();
15341539
};
1535-
exports.version = "19.2.0-www-modern-f9ae0a4c-20250527";
1540+
exports.version = "19.2.0-www-modern-283f87f0-20250527";
15361541
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
15371542
"function" ===
15381543
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/React-prod.classic.js

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ var dynamicFeatureFlags = require("ReactFeatureFlags"),
1717
enableRenderableContext = dynamicFeatureFlags.enableRenderableContext,
1818
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
1919
renameElementSymbol = dynamicFeatureFlags.renameElementSymbol,
20+
enableViewTransition = dynamicFeatureFlags.enableViewTransition,
2021
REACT_LEGACY_ELEMENT_TYPE = Symbol.for("react.element"),
2122
REACT_ELEMENT_TYPE = renameElementSymbol
2223
? Symbol.for("react.transitional.element")
@@ -356,8 +357,9 @@ var reportGlobalError =
356357
function startTransition(scope, options) {
357358
var prevTransition = ReactSharedInternals.T,
358359
currentTransition = {};
359-
currentTransition.types =
360-
null !== prevTransition ? prevTransition.types : null;
360+
enableViewTransition &&
361+
(currentTransition.types =
362+
null !== prevTransition ? prevTransition.types : null);
361363
enableTransitionTracing &&
362364
((currentTransition.name =
363365
void 0 !== options && void 0 !== options.name ? options.name : null),
@@ -382,13 +384,15 @@ function startTransition(scope, options) {
382384
}
383385
}
384386
function addTransitionType(type) {
385-
var transition = ReactSharedInternals.T;
386-
if (null !== transition) {
387-
var transitionTypes = transition.types;
388-
null === transitionTypes
389-
? (transition.types = [type])
390-
: -1 === transitionTypes.indexOf(type) && transitionTypes.push(type);
391-
} else startTransition(addTransitionType.bind(null, type));
387+
if (enableViewTransition) {
388+
var transition = ReactSharedInternals.T;
389+
if (null !== transition) {
390+
var transitionTypes = transition.types;
391+
null === transitionTypes
392+
? (transition.types = [type])
393+
: -1 === transitionTypes.indexOf(type) && transitionTypes.push(type);
394+
} else startTransition(addTransitionType.bind(null, type));
395+
}
392396
}
393397
var ReactCompilerRuntime = { __proto__: null, c: useMemoCache };
394398
exports.Children = {
@@ -631,4 +635,4 @@ exports.useSyncExternalStore = function (
631635
exports.useTransition = function () {
632636
return ReactSharedInternals.H.useTransition();
633637
};
634-
exports.version = "19.2.0-www-classic-f9ae0a4c-20250527";
638+
exports.version = "19.2.0-www-classic-283f87f0-20250527";

‎compiled/facebook-www/React-prod.modern.js

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ var dynamicFeatureFlags = require("ReactFeatureFlags"),
1717
enableRenderableContext = dynamicFeatureFlags.enableRenderableContext,
1818
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
1919
renameElementSymbol = dynamicFeatureFlags.renameElementSymbol,
20+
enableViewTransition = dynamicFeatureFlags.enableViewTransition,
2021
REACT_LEGACY_ELEMENT_TYPE = Symbol.for("react.element"),
2122
REACT_ELEMENT_TYPE = renameElementSymbol
2223
? Symbol.for("react.transitional.element")
@@ -356,8 +357,9 @@ var reportGlobalError =
356357
function startTransition(scope, options) {
357358
var prevTransition = ReactSharedInternals.T,
358359
currentTransition = {};
359-
currentTransition.types =
360-
null !== prevTransition ? prevTransition.types : null;
360+
enableViewTransition &&
361+
(currentTransition.types =
362+
null !== prevTransition ? prevTransition.types : null);
361363
enableTransitionTracing &&
362364
((currentTransition.name =
363365
void 0 !== options && void 0 !== options.name ? options.name : null),
@@ -382,13 +384,15 @@ function startTransition(scope, options) {
382384
}
383385
}
384386
function addTransitionType(type) {
385-
var transition = ReactSharedInternals.T;
386-
if (null !== transition) {
387-
var transitionTypes = transition.types;
388-
null === transitionTypes
389-
? (transition.types = [type])
390-
: -1 === transitionTypes.indexOf(type) && transitionTypes.push(type);
391-
} else startTransition(addTransitionType.bind(null, type));
387+
if (enableViewTransition) {
388+
var transition = ReactSharedInternals.T;
389+
if (null !== transition) {
390+
var transitionTypes = transition.types;
391+
null === transitionTypes
392+
? (transition.types = [type])
393+
: -1 === transitionTypes.indexOf(type) && transitionTypes.push(type);
394+
} else startTransition(addTransitionType.bind(null, type));
395+
}
392396
}
393397
var ReactCompilerRuntime = { __proto__: null, c: useMemoCache };
394398
exports.Children = {
@@ -631,4 +635,4 @@ exports.useSyncExternalStore = function (
631635
exports.useTransition = function () {
632636
return ReactSharedInternals.H.useTransition();
633637
};
634-
exports.version = "19.2.0-www-modern-f9ae0a4c-20250527";
638+
exports.version = "19.2.0-www-modern-283f87f0-20250527";

0 commit comments

Comments
 (0)