[Compiler] Avoid capturing global setStates for no-derived-computations lint (facebook#35135)

Summary:
This only matters when enableTreatSetIdentifiersAsStateSetters=true

This pattern is still bad. But Right now the validation can only
recommend to move stuff to "calculate in render"

A global setState should not be moved to render, not even conditionally
and you can't remove state without crossing Component boundaries, which
makes this a different kind of fix.

So while we are only suggesting "calculate in render" as a fix we should
disallow the lint from throwing in this case IMO

Test Plan:
Added a fixture

---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/35135).
* __->__ facebook#35135
* facebook#35134

DiffTrain build for [257b033](facebook@257b033)

Author: pull[bot]

compiled/eslint-plugin-react-hooks/index.js

@@ -52418,16 +52418,18 @@ function isNamedIdentifier(place) {
 }
 function validateNoDerivedComputationsInEffects_exp(fn) {
     const functions = new Map();
+    const candidateDependencies = new Map();
     const derivationCache = new DerivationCache();
     const errors = new CompilerError();
-    const effects = new Set();
+    const effectsCache = new Map();
     const setStateLoads = new Map();
     const setStateUsages = new Map();
     const context = {
         functions,
+        candidateDependencies,
         errors,
         derivationCache,
-        effects,
+        effectsCache,
         setStateLoads,
         setStateUsages,
     };
@@ -52464,8 +52466,8 @@ function validateNoDerivedComputationsInEffects_exp(fn) {
         }
         context.derivationCache.checkForChanges();
     } while (context.derivationCache.snapshot());
-    for (const effect of effects) {
-        validateEffect(effect, context);
+    for (const [, effect] of effectsCache) {
+        validateEffect(effect.effect, effect.dependencies, context);
     }
     return errors.asResult();
 }
@@ -52549,8 +52551,12 @@ function recordInstructionDerivations(instr, context, isFirstPass) {
             value.args[0].kind === 'Identifier' &&
             value.args[1].kind === 'Identifier') {
             const effectFunction = context.functions.get(value.args[0].identifier.id);
-            if (effectFunction != null) {
-                context.effects.add(effectFunction.loweredFunc.func);
+            const deps = context.candidateDependencies.get(value.args[1].identifier.id);
+            if (effectFunction != null && deps != null) {
+                context.effectsCache.set(value.args[0].identifier.id, {
+                    effect: effectFunction.loweredFunc.func,
+                    dependencies: deps,
+                });
             }
         }
         else if (isUseStateType(lvalue.identifier) && value.args.length > 0) {
@@ -52559,6 +52565,9 @@ function recordInstructionDerivations(instr, context, isFirstPass) {
             return;
         }
     }
+    else if (value.kind === 'ArrayExpression') {
+        context.candidateDependencies.set(lvalue.identifier.id, value);
+    }
     for (const operand of eachInstructionOperand(instr)) {
         if (context.setStateLoads.has(operand.identifier.id)) {
             const rootSetStateId = getRootSetState(operand.identifier.id, context.setStateLoads);
@@ -52715,11 +52724,19 @@ function getFnLocalDeps(fn) {
     }
     return deps;
 }
-function validateEffect(effectFunction, context) {
+function validateEffect(effectFunction, dependencies, context) {
     var _a;
     const seenBlocks = new Set();
     const effectDerivedSetStateCalls = [];
     const effectSetStateUsages = new Map();
+    for (const dep of dependencies.elements) {
+        if (dep.kind === 'Identifier') {
+            const root = getRootSetState(dep.identifier.id, context.setStateLoads);
+            if (root !== null) {
+                effectSetStateUsages.set(root, new Set([dep.loc]));
+            }
+        }
+    }
     let cleanUpFunctionDeps;
     const globals = new Set();
     for (const block of effectFunction.body.blocks.values()) {
@@ -52749,6 +52766,10 @@ function validateEffect(effectFunction, context) {
                 isSetStateType(instr.value.callee.identifier) &&
                 instr.value.args.length === 1 &&
                 instr.value.args[0].kind === 'Identifier') {
+                const calleeMetadata = context.derivationCache.cache.get(instr.value.callee.identifier.id);
+                if ((calleeMetadata === null || calleeMetadata === void 0 ? void 0 : calleeMetadata.typeOfValue) != 'fromState') {
+                    continue;
+                }
                 const argMetadata = context.derivationCache.cache.get(instr.value.args[0].identifier.id);
                 if (argMetadata !== undefined) {
                     effectDerivedSetStateCalls.push({

compiled/facebook-www/REVISION

@@ -1 +1 @@
-093b3246e162c2a6fd1a376506ed1144ed140226
+257b033fc7b0518e7b1db32ca24e2354933b9d0e

compiled/facebook-www/REVISION_TRANSFORMS

@@ -1 +1 @@
-093b3246e162c2a6fd1a376506ed1144ed140226
+257b033fc7b0518e7b1db32ca24e2354933b9d0e

compiled/facebook-www/React-dev.classic.js

@@ -1499,7 +1499,7 @@ __DEV__ &&
     exports.useTransition = function () {
       return resolveDispatcher().useTransition();
     };
-    exports.version = "19.3.0-www-classic-093b3246-20251113";
+    exports.version = "19.3.0-www-classic-257b033f-20251113";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-dev.modern.js

@@ -1499,7 +1499,7 @@ __DEV__ &&
     exports.useTransition = function () {
       return resolveDispatcher().useTransition();
     };
-    exports.version = "19.3.0-www-modern-093b3246-20251113";
+    exports.version = "19.3.0-www-modern-257b033f-20251113";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-prod.classic.js

@@ -606,4 +606,4 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.3.0-www-classic-093b3246-20251113";
+exports.version = "19.3.0-www-classic-257b033f-20251113";

compiled/facebook-www/React-prod.modern.js

@@ -606,4 +606,4 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.3.0-www-modern-093b3246-20251113";
+exports.version = "19.3.0-www-modern-257b033f-20251113";

compiled/facebook-www/React-profiling.classic.js

@@ -610,7 +610,7 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.3.0-www-classic-093b3246-20251113";
+exports.version = "19.3.0-www-classic-257b033f-20251113";
 "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
   "function" ===
     typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-profiling.modern.js

@@ -610,7 +610,7 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.3.0-www-modern-093b3246-20251113";
+exports.version = "19.3.0-www-modern-257b033f-20251113";
 "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
   "function" ===
     typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.classic.js

@@ -20466,10 +20466,10 @@ __DEV__ &&
     (function () {
       var internals = {
         bundleType: 1,
-        version: "19.3.0-www-classic-093b3246-20251113",
+        version: "19.3.0-www-classic-257b033f-20251113",
         rendererPackageName: "react-art",
         currentDispatcherRef: ReactSharedInternals,
-        reconcilerVersion: "19.3.0-www-classic-093b3246-20251113"
+        reconcilerVersion: "19.3.0-www-classic-257b033f-20251113"
       };
       internals.overrideHookState = overrideHookState;
       internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -20504,7 +20504,7 @@ __DEV__ &&
     exports.Shape = Shape;
     exports.Surface = Surface;
     exports.Text = Text;
-    exports.version = "19.3.0-www-classic-093b3246-20251113";
+    exports.version = "19.3.0-www-classic-257b033f-20251113";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&