Merge da60063 into 3dbf378

Author: BioPhoton

…b/fixtures/configs/code-pushup.config.ts …/cli/mocks/configs/code-pushup.config.tstesting/test-fixtures/src/lib/fixtures/configs/code-pushup.config.ts renamed to packages/cli/mocks/configs/code-pushup.config.ts testing/test-fixtures/src/lib/fixtures/configs/code-pushup.config.ts renamed to packages/cli/mocks/configs/code-pushup.config.ts

@@ -1,5 +1,3 @@
-import { type CoreConfig } from '@code-pushup/models';
-
 export default {
   upload: {
     organization: 'code-pushup',
@@ -42,4 +40,4 @@ export default {
       icon: 'javascript',
     },
   ],
-} satisfies CoreConfig;
+};

packages/cli/mocks/configs/code-pushup.needs-tsconfig.config.ts

@@ -0,0 +1,12 @@
+// the point is to test runtime import which requires tsconfig for path aliases
+
+/* eslint-disable import/no-unresolved */
+// @ts-expect-error - test tsconfig paths missing in config
+import customPlugin from '@example/custom-plugin';
+
+/* eslint-enable import/no-unresolved */
+const config = {
+  plugins: [customPlugin],
+};
+
+export default config;

…rc/lib/fixtures/configs/custom-plugin.ts …kages/cli/mocks/configs/custom-plugin.tstesting/test-fixtures/src/lib/fixtures/configs/custom-plugin.ts renamed to packages/cli/mocks/configs/custom-plugin.ts testing/test-fixtures/src/lib/fixtures/configs/custom-plugin.ts renamed to packages/cli/mocks/configs/custom-plugin.ts

@@ -0,0 +1,11 @@
+{
+  "compilerOptions": {
+    "baseUrl": ".",
+    "allowImportingTsExtensions": true,
+    "moduleResolution": "node",
+    "paths": {
+      "@example/custom-plugin": ["./custom-plugin.ts"]
+    }
+  },
+  "include": ["*.ts"]
+}

packages/cli/mocks/configs/tsconfig.json

@@ -8,12 +8,8 @@ const configDirPath = path.join(
   '..',
   '..',
   '..',
-  '..',
-  'testing',
-  'test-fixtures',
-  'src',
-  'lib',
-  'fixtures',
+  'cli',
+  'mocks',
   'configs',
 );
 
@@ -24,22 +20,13 @@ describe('coreConfigMiddleware', () => {
     skipPlugins: [],
   };
 
-  it.each(['ts', 'mjs', 'js'])(
-    'should load a valid .%s config',
-    async extension => {
-      const config = await coreConfigMiddleware({
-        config: path.join(configDirPath, `code-pushup.config.${extension}`),
-        ...CLI_DEFAULTS,
-      });
-      expect(config.config).toContain(`code-pushup.config.${extension}`);
-      expect(config.upload?.project).toContain(extension);
-    },
-  );
-
-  it('should throw with invalid config path', async () => {
-    await expect(
-      coreConfigMiddleware({ config: 'wrong/path/to/config', ...CLI_DEFAULTS }),
-    ).rejects.toThrow(/File '.*' does not exist/);
+  it('should load a valid .ts config', async () => {
+    const config = await coreConfigMiddleware({
+      config: path.join(configDirPath, `code-pushup.config.ts`),
+      ...CLI_DEFAULTS,
+    });
+    expect(config.config).toContain(`code-pushup.config.ts`);
+    expect(config.upload?.project).toContain('ts');
   });
 
   it('should load config which relies on provided --tsconfig', async () => {
@@ -54,16 +41,4 @@ describe('coreConfigMiddleware', () => {
       }),
     ).resolves.toBeTruthy();
   });
-
-  it('should throw if --tsconfig is missing but needed to resolve import', async () => {
-    await expect(
-      coreConfigMiddleware({
-        config: path.join(
-          configDirPath,
-          'code-pushup.needs-tsconfig.config.ts',
-        ),
-        ...CLI_DEFAULTS,
-      }),
-    ).rejects.toThrow("Cannot find package '@example/custom-plugin'");
-  });
 });

packages/cli/src/lib/implementation/core-config.middleware.int.test.ts

@@ -0,0 +1,24 @@
+const customPluginConfig = {
+  slug: 'good-feels',
+  title: 'Good feels',
+  icon: 'javascript',
+  audits: [
+    {
+      slug: 'always-perfect',
+      title: 'Always perfect',
+    },
+  ],
+  runner: () => [
+    {
+      slug: 'always-perfect',
+      score: 1,
+      value: 100,
+      displayValue: '✅ Perfect! 👌',
+    },
+  ],
+};
+
+export function customPlugin() {
+  return customPluginConfig;
+}
+export default customPluginConfig;