Skip to content

Commit 068b335

Browse files
committed
feat(plugin-eslint): rename eslintConfigFromNxProjects to eslintConfigFromAllNxProjects
DEPRECATION: the old eslintConfigFromNxProjects stays as alias and is now deprecated Signed-off-by: Vojtech Masek <vojtech@flowup.cz>
1 parent ca95d37 commit 068b335

File tree

7 files changed

+23
-13
lines changed

7 files changed

+23
-13
lines changed

code-pushup.config.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import coveragePlugin, {
1212
getNxCoveragePaths,
1313
} from './dist/packages/plugin-coverage';
1414
import eslintPlugin, {
15-
eslintConfigFromNxProjects,
15+
eslintConfigFromAllNxProjects,
1616
} from './dist/packages/plugin-eslint';
1717
import jsPackagesPlugin from './dist/packages/plugin-js-packages';
1818
import {
@@ -46,7 +46,7 @@ const config: CoreConfig = {
4646
}),
4747

4848
plugins: [
49-
await eslintPlugin(await eslintConfigFromNxProjects()),
49+
await eslintPlugin(await eslintConfigFromAllNxProjects()),
5050

5151
await coveragePlugin({
5252
coverageToolCommand: {

packages/plugin-eslint/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,15 +59,15 @@ Detected ESLint rules are mapped to Code PushUp audits. Audit reports are calcul
5959

6060
If you're using an Nx monorepo, additional helper functions are provided to simplify your configuration:
6161

62-
- If you wish to combine all projects in your workspace into one report, use the `eslintConfigFromNxProjects` helper:
62+
- If you wish to combine all projects in your workspace into one report, use the `eslintConfigFromAllNxProjects` helper:
6363

6464
```js
65-
import eslintPlugin, { eslintConfigFromNxProjects } from '@code-pushup/eslint-plugin';
65+
import eslintPlugin, { eslintConfigFromAllNxProjects } from '@code-pushup/eslint-plugin';
6666

6767
export default {
6868
plugins: [
6969
// ...
70-
await eslintPlugin(await eslintConfigFromNxProjects()),
70+
await eslintPlugin(await eslintConfigFromAllNxProjects()),
7171
],
7272
};
7373
```

packages/plugin-eslint/src/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,5 @@ export type { ESLintPluginConfig } from './lib/config';
77
export {
88
eslintConfigFromNxProject,
99
eslintConfigFromNxProjects,
10+
eslintConfigFromAllNxProjects,
1011
} from './lib/nx';

packages/plugin-eslint/src/lib/nx.integration.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { fileURLToPath } from 'node:url';
33
import { setWorkspaceRoot, workspaceRoot } from 'nx/src/utils/workspace-root';
44
import type { MockInstance } from 'vitest';
55
import { type ESLintTarget } from './config';
6-
import { eslintConfigFromNxProject, eslintConfigFromNxProjects } from './nx';
6+
import { eslintConfigFromAllNxProjects, eslintConfigFromNxProject } from './nx';
77

88
describe('Nx helpers', () => {
99
let cwdSpy: MockInstance<[], string>;
@@ -33,7 +33,7 @@ describe('Nx helpers', () => {
3333

3434
describe('create config from all Nx projects', () => {
3535
it('should include eslintrc and patterns of each project', async () => {
36-
await expect(eslintConfigFromNxProjects()).resolves.toEqual([
36+
await expect(eslintConfigFromAllNxProjects()).resolves.toEqual([
3737
{
3838
eslintrc: './packages/cli/.eslintrc.json',
3939
patterns: [

packages/plugin-eslint/src/lib/nx/find-all-projects.ts

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,21 +9,27 @@ import { nxProjectsToConfig } from './projects-to-config';
99
*
1010
* @example
1111
* import eslintPlugin, {
12-
* eslintConfigFromNxProjects,
12+
* eslintConfigFromAllNxProjects,
1313
* } from '@code-pushup/eslint-plugin';
1414
*
1515
* export default {
1616
* plugins: [
1717
* await eslintPlugin(
18-
* await eslintConfigFromNxProjects()
18+
* await eslintConfigFromAllNxProjects()
1919
* )
2020
* ]
2121
* }
2222
*
2323
* @returns ESLint config and patterns, intended to be passed to {@link eslintPlugin}
2424
*/
25-
export async function eslintConfigFromNxProjects(): Promise<ESLintTarget[]> {
25+
export async function eslintConfigFromAllNxProjects(): Promise<ESLintTarget[]> {
2626
const { createProjectGraphAsync } = await import('@nx/devkit');
2727
const projectGraph = await createProjectGraphAsync({ exitOnError: false });
2828
return nxProjectsToConfig(projectGraph);
2929
}
30+
31+
/**
32+
* @deprecated
33+
* Helper is renamed, please use `eslintConfigFromAllNxProjects` function instead.
34+
*/
35+
export const eslintConfigFromNxProjects = eslintConfigFromAllNxProjects;

packages/plugin-eslint/src/lib/nx/find-project-with-deps.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ import { findAllDependencies } from './traverse-graph';
55
/**
66
* Accepts a target Nx projects, finds projects it depends on, and converts lint configurations to Code PushUp ESLint plugin parameters.
77
*
8-
* Use when you wish to include a targetted subset of your Nx monorepo in your Code PushUp project.
9-
* If you prefer to include all Nx projects, refer to {@link eslintConfigFromNxProjects} instead.
8+
* Use when you wish to include a targeted subset of your Nx monorepo in your Code PushUp project.
9+
* If you prefer to include all Nx projects, refer to {@link eslintConfigFromAllNxProjects} instead.
1010
*
1111
* @example
1212
* import eslintPlugin, {
Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,5 @@
1-
export { eslintConfigFromNxProjects } from './find-all-projects';
1+
export {
2+
eslintConfigFromNxProjects,
3+
eslintConfigFromAllNxProjects,
4+
} from './find-all-projects';
25
export { eslintConfigFromNxProject } from './find-project-with-deps';

0 commit comments

Comments
 (0)