Skip to content

Be ready to ship into NPM and clean all the old code #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Apr 19, 2020
Merged

Be ready to ship into NPM and clean all the old code #13

merged 29 commits into from
Apr 19, 2020

Conversation

williamdes
Copy link
Member

  • Remove old scripts
  • Improve README.md
  • Make it npm package-able
  • Clean demo
  • Have real tests

@williamdes
Copy link
Member Author

@gregwebs 🏓 I am near to be finished
I will publish the npm version and give owership in it to you

@williamdes
Copy link
Member Author

The tests did pass because jQuery was not loaded in the old test suite so the values where undefined and the tests did pass.
So adding jQuery to the test bench allowed the tests to pass after changing the assertions to undefined.
@williamdes
Copy link
Member Author

Tests

image

Demo

image

@williamdes
Copy link
Member Author

Done.

williamdes added a commit to williamdes/phpmyadmintest that referenced this pull request Apr 18, 2020
Ref: code-lts/jquery-uitablefilter#13
Signed-off-by: William Desportes <williamdes@wdes.fr>
@gregwebs
Copy link
Collaborator

thanks! I added you as a contributor

@gregwebs gregwebs merged commit 54753c2 into code-lts:master Apr 19, 2020
@williamdes
Copy link
Member Author

Thank you so much, I will continue my work then 💪

@williamdes
Copy link
Member Author

cc @natinusala

@williamdes williamdes self-assigned this Apr 20, 2020
@williamdes
Copy link
Member Author

@gregwebs the URL mentioned on the repository introduction "http://projects.gregweber.info/uitablefilter" seems broken, could you please have a look?

@natinusala
Copy link

Sorry why are there unnamed commits from me on an unknown branch

Why did you tag me

What happened

@williamdes
Copy link
Member Author

williamdes commented Apr 20, 2020

Hi @natinusala
I merged your fork into my work and all did get merged into the main repository.
You can now delete your fork if you want.

I did start my work based on your fork and then I merged the main repo into it and now the main repo has all the work. Yours and mine.

image

@natinusala
Copy link

Okay so it seems I did that fork back at the time when I didn't know how to use git and I didn't add any messages to my commits 😂

I honestly don't remember what I was even doing with that fork or what I changed or why I used that library... feel free to squash and/or reword my commits, it looks kinda weird on the history

@williamdes
Copy link
Member Author

williamdes commented Apr 20, 2020

Unfortunately this is now part of the history 😆
Nobody will blame you it was in 2013 🙈

@natinusala
Copy link

Nobody will blame you if you rebase and force push 😋

@williamdes
Copy link
Member Author

Old history is copied everywhere ...
I would need @gregwebs approval to do so and I do not like it very much because the history is very old ^^

PS: If you see this notification please see #13 (comment)

@gregwebs
Copy link
Collaborator

gregwebs commented Apr 20, 2020

@gregwebs the URL mentioned on the repository introduction "http://projects.gregweber.info/uitablefilter" seems broken, could you please have a look?

I did have the demo there at one time. I would prefer to just use github for everything now, perhaps github.io if needed.

@williamdes
Copy link
Member Author

Could you activate github pages on this repository so we can use https://gregwebs.github.io/jquery-uitablefilter/demo/flavorzoom.html
Maybe a gh-pages branch is the best option

@gregwebs
Copy link
Collaborator

I turned it on. It seems to force me to use the master branch, I am trying to figure out how to change it.

@gregwebs
Copy link
Collaborator

okay, now it is using master but set to the docs folder.

@williamdes
Copy link
Member Author

okay, now it is using master but set to the docs folder.

Perfect, you can change the link now 😎
It should serve all contents from docs but it works fine as it is 🤔

williamdes added a commit to williamdes/phpmyadmintest that referenced this pull request Apr 24, 2020
Ref: code-lts/jquery-uitablefilter#13
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes
Copy link
Member Author

@gregwebs just in case you would be interested, I created @code-lts if you want to give-away your repository :)

@gregwebs
Copy link
Collaborator

That would be great. I tried to do this and then it stated "You don’t have the permission to create public repositories on code-lts"

@williamdes
Copy link
Member Author

I invited you, and you should be able to "transfer" the repository :)

Let me know if it does not work

Thank you for accepting!

@gregwebs
Copy link
Collaborator

transferred

@williamdes
Copy link
Member Author

🎉

williamdes added a commit to williamdes/phpmyadmintest that referenced this pull request May 3, 2020
Ref: code-lts/jquery-uitablefilter#13
Signed-off-by: William Desportes <williamdes@wdes.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants