-
Notifications
You must be signed in to change notification settings - Fork 20
Be ready to ship into NPM and clean all the old code #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
williamdes
commented
Apr 18, 2020
- Remove old scripts
- Improve README.md
- Make it npm package-able
- Clean demo
- Have real tests
Who cares about SVN now ? This file was added 12 years ago !
@gregwebs 🏓 I am near to be finished |
The tests did pass because jQuery was not loaded in the old test suite so the values where undefined and the tests did pass. So adding jQuery to the test bench allowed the tests to pass after changing the assertions to undefined.
Done. |
Ref: code-lts/jquery-uitablefilter#13 Signed-off-by: William Desportes <williamdes@wdes.fr>
thanks! I added you as a contributor |
Thank you so much, I will continue my work then 💪 |
cc @natinusala |
@gregwebs the URL mentioned on the repository introduction "http://projects.gregweber.info/uitablefilter" seems broken, could you please have a look? |
Sorry why are there unnamed commits from me on an unknown branch Why did you tag me What happened |
Hi @natinusala I did start my work based on your fork and then I merged the main repo into it and now the main repo has all the work. Yours and mine. |
Okay so it seems I did that fork back at the time when I didn't know how to use git and I didn't add any messages to my commits 😂 I honestly don't remember what I was even doing with that fork or what I changed or why I used that library... feel free to squash and/or reword my commits, it looks kinda weird on the history |
Unfortunately this is now part of the history 😆 |
Nobody will blame you if you rebase and force push 😋 |
Old history is copied everywhere ... PS: If you see this notification please see #13 (comment) |
I did have the demo there at one time. I would prefer to just use github for everything now, perhaps github.io if needed. |
Could you activate github pages on this repository so we can use https://gregwebs.github.io/jquery-uitablefilter/demo/flavorzoom.html |
I turned it on. It seems to force me to use the master branch, I am trying to figure out how to change it. |
okay, now it is using master but set to the |
Perfect, you can change the link now 😎 |
Ref: code-lts/jquery-uitablefilter#13 Signed-off-by: William Desportes <williamdes@wdes.fr>
That would be great. I tried to do this and then it stated "You don’t have the permission to create public repositories on code-lts" |
I invited you, and you should be able to "transfer" the repository :) Let me know if it does not work Thank you for accepting! |
transferred |
🎉 |
Ref: code-lts/jquery-uitablefilter#13 Signed-off-by: William Desportes <williamdes@wdes.fr>