Skip to content

Commit 3ecf6d1

Browse files
committed
perf: tag instead of pr_create PR number on workflow_dispatch
1 parent 435ff5b commit 3ecf6d1

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

.github/workflows/k8s_apply.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ jobs:
1818
runs-on: [self-hosted, "${{ github.event_name == 'pull_request' && github.event.pull_request.base.ref || github.ref_name }}"]
1919
environment: ${{ github.event_name == 'pull_request' && github.event.pull_request.base.ref || github.ref_name }}
2020
env:
21+
ENVIRONMENT_NAME: ${{ github.event_name == 'pull_request' && github.event.pull_request.base.ref || github.ref_name }}
2122
KUBELOGIN_VERSION: "v0.0.25"
2223
KUBERNETES_CLUSTER_REPO_NAME: "${{ vars.KUBERNETES_CLUSTER_REPO_NAME }}"
2324
KUBERNETES_CLUSTER_NAME: "${{ vars.KUBERNETES_CLUSTER_NAME }}"
@@ -73,10 +74,11 @@ jobs:
7374
7475
- name: Assert Deploy Success
7576
shell: bash
77+
if: env.ENVIRONMENT_NAME == 'dev'
7678
run: |
7779
bash cicd-deployment-scripts/k8s/assert_deploy_success.sh \
7880
-n ${{ env.KUBERNETES_NAMESPACE }} \
79-
-p ${{ github.event.pull_request.number }}
81+
-p ${{ github.event_name == 'release' && github.event.release.tag_name || github.event.pull_request.number }}
8082
8183
- name: Revert on failure
8284
if: failure()

.github/workflows/k8s_edit.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,5 +80,5 @@ jobs:
8080
-t "$PR_TITLE" \
8181
-o "${{ github.repository_owner }}" \
8282
-r "${{ github.event.repository.name }}" \
83-
-n "${{ github.event_name == 'release' && 'release' || github.event.pull_request.number }}" \
83+
-n "${{ github.event_name == 'release' && github.event.release.tag_name || github.event.pull_request.number }}" \
8484
-k "${{ env.KUBERNETES_CLUSTER_REPO_NAME }}" \

0 commit comments

Comments
 (0)