clean up receipt_email, add test for non-nil name

Author: zacck

test/lib/code_corps/emails/base_email_test.exs

@@ -3,8 +3,14 @@ defmodule CodeCorps.Emails.BaseEmailTest do
   use Bamboo.Test
   alias CodeCorps.Emails.BaseEmail
 
-  test "get name returns there on nil name" do
+  test "get_name returns there on nil name" do
     user = %CodeCorps.User{}
     assert BaseEmail.get_name(user) == "there"
   end
+
+  test "get_name returns first_name of user" do
+    f_name = "Zacck"
+    user = %CodeCorps.User{first_name: f_name}
+    assert BaseEmail.get_name(user) == f_name
+  end
 end

test/lib/code_corps/emails/receipt_email_test.exs

@@ -4,8 +4,6 @@ defmodule CodeCorps.Emails.ReceiptEmailTest do
 
   alias CodeCorps.Emails.ReceiptEmail
 
-
-
   test "receipt email works" do
     invoice_fixture = CodeCorps.StripeTesting.Helpers.load_fixture("invoice")