Get rid of nondeterminism issues in email tests

Author: begedin

test/lib/code_corps/emails/transmissions/project_approval_request_test.exs

@@ -25,7 +25,7 @@ defmodule CodeCorps.Emails.Transmissions.ProjectApprovalRequestTest do
       admin_1 = insert(:user, admin: true)
       admin_2 = insert(:user, admin: true)
 
-      %{substitution_data: data, recipients: [recipient_1, recipient_2]} =
+      %{substitution_data: data, recipients: recipients} =
         ProjectApprovalRequest.build(project)
 
       assert data.from_name == "Code Corps"
@@ -38,10 +38,8 @@ defmodule CodeCorps.Emails.Transmissions.ProjectApprovalRequestTest do
       assert data.project_url == "http://localhost:4200/#{project.organization.slug}/#{project.slug}"
       assert data.subject == "#{project.title} is asking to be approved"
 
-      assert recipient_1.address.email == admin_1.email
-      assert recipient_1.address.name == admin_1.first_name
-      assert recipient_2.address.email == admin_2.email
-      assert recipient_2.address.name == admin_2.first_name
+      assert %{address: %{email: admin_1.email, name: admin_1.first_name}} in recipients
+      assert %{address: %{email: admin_2.email, name: admin_2.first_name}} in recipients
     end
   end
 end

test/lib/code_corps/emails/transmissions/project_approved_test.exs

@@ -24,7 +24,7 @@ defmodule CodeCorps.Emails.Transmissions.ProjectApprovedTest do
       %{user: owner_1} = insert(:project_user, project: project, role: "owner")
       %{user: owner_2} = insert(:project_user, project: project, role: "owner")
 
-      %{substitution_data: data, recipients: [recipient_1, recipient_2]} =
+      %{substitution_data: data, recipients: recipients} =
         ProjectApproved.build(project)
 
       assert data.from_name == "Code Corps"
@@ -34,10 +34,8 @@ defmodule CodeCorps.Emails.Transmissions.ProjectApprovedTest do
       assert data.project_url == "http://localhost:4200/#{project.organization.slug}/#{project.slug}"
       assert data.subject == "#{project.title} is approved!"
 
-      assert recipient_1.address.email == owner_1.email
-      assert recipient_1.address.name == owner_1.first_name
-      assert recipient_2.address.email == owner_2.email
-      assert recipient_2.address.name == owner_2.first_name
+      assert %{address: %{email: owner_1.email, name: owner_1.first_name}} in recipients
+      assert %{address: %{email: owner_2.email, name: owner_2.first_name}} in recipients
     end
   end
 end

test/lib/code_corps/emails/transmissions/project_user_request_test.exs

@@ -26,7 +26,7 @@ defmodule CodeCorps.Emails.Transmissions.ProjectUserRequestTest do
       %{user: owner_1} = insert(:project_user, project: project, role: "owner")
       %{user: owner_2} = insert(:project_user, project: project, role: "owner")
 
-      %{substitution_data: data, recipients: [recipient_1, recipient_2]} =
+      %{substitution_data: data, recipients: recipients} =
         ProjectUserRequest.build(project_user)
 
       assert data.from_name == "Code Corps"
@@ -39,10 +39,8 @@ defmodule CodeCorps.Emails.Transmissions.ProjectUserRequestTest do
       assert data.user_first_name == requesting_user.first_name
       assert data.subject == "#{requesting_user.first_name} wants to join #{project.title}"
 
-      assert recipient_1.address.email == owner_1.email
-      assert recipient_1.address.name == owner_1.first_name
-      assert recipient_2.address.email == owner_2.email
-      assert recipient_2.address.name == owner_2.first_name
+      assert %{address: %{email: owner_1.email, name: owner_1.first_name}} in recipients
+      assert %{address: %{email: owner_2.email, name: owner_2.first_name}} in recipients
     end
   end
 end