Skip to content

Commit 7f2d520

Browse files
committed
Fix issues from code review
1 parent 0ba3ab9 commit 7f2d520

File tree

3 files changed

+6
-64
lines changed

3 files changed

+6
-64
lines changed

lib/code_corps/policy/organization_view_test.exs

Lines changed: 0 additions & 62 deletions
This file was deleted.

test/lib/code_corps/messages/messages_test.exs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -320,7 +320,11 @@ defmodule CodeCorps.MessagesTest do
320320
conversation_id: conversation.id
321321
}
322322

323-
{:ok, %ConversationPart{}} = Messages.add_part(attrs)
323+
{:ok, %ConversationPart{} = conversation_part} = Messages.add_part(attrs)
324+
325+
assert conversation_part.author_id == user.id
326+
assert conversation_part.body == "Test body"
327+
assert conversation_part.conversation_id == conversation.id
324328
end
325329
end
326330
end

test/lib/code_corps/policy/helpers_test.exs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ defmodule CodeCorps.Policy.HelpersTest do
112112
assert result.id == conversation.id
113113
end
114114

115-
test "should return conversation of a Conversation" do
115+
test "should return conversation of a ConversationPart" do
116116
conversation = insert(:conversation)
117117
conversation_part = insert(:conversation_part, conversation: conversation)
118118
result = Helpers.get_conversation(conversation_part)

0 commit comments

Comments
 (0)