Fix 2.13 deprecations

Author: ashawley

src/main/scala/codecheck/github/api/GitHubAPI.scala

@@ -81,7 +81,7 @@ class GitHubAPI(token: String, client: Transport, tokenType: String = "token", d
             deferred.success(result)
         }
       }
-      def onThrowable(t: Throwable) {
+      def onThrowable(t: Throwable): Unit = {
         deferred.failure(t)
       }
     })

src/main/scala/codecheck/github/api/OAuthAPI.scala

@@ -63,7 +63,7 @@ class OAuthAPI(clientId: String, clientSecret: String, redirectUri: String, clie
           case None => deferred.success(AccessToken(json))
         }
       }
-      def onThrowable(t: Throwable) {
+      def onThrowable(t: Throwable): Unit = {
         deferred.failure(t)
       }
     })

src/main/scala/codecheck/github/app/commands/MilestoneCommand.scala

@@ -182,7 +182,7 @@ class MilestoneCommand(val api: GitHubAPI) extends Command {
           List(
             m.number,
             m.title,
-            m.open_issues + "/" + (m.open_issues + m.closed_issues),
+            s"${m.open_issues}/${m.open_issues + m.closed_issues}",
             m.due_on.map(_.toString("yyyy-MM-dd")).getOrElse("")
           )
         }

src/main/scala/codecheck/github/transport/asynchttp19/AsyncHttp19Transport.scala

@@ -43,7 +43,7 @@ class AsyncHttp19Request(request: AsyncHttpClient#BoundRequestBuilder) extends R
         handler.onCompleted(new AsyncHttp19Response(res))
         res
       }
-      override def onThrowable(t: Throwable) {
+      override def onThrowable(t: Throwable): Unit = {
         handler.onThrowable(t)
         super.onThrowable(t)
       }

src/main/scala/codecheck/github/transport/asynchttp20/AsyncHttp20Transport.scala

@@ -43,7 +43,7 @@ class AsyncHttp20Request(request: BoundRequestBuilder) extends Request {
         handler.onCompleted(new AsyncHttp20Response(res))
         res
       }
-      override def onThrowable(t: Throwable) {
+      override def onThrowable(t: Throwable): Unit = {
         handler.onThrowable(t)
         super.onThrowable(t)
       }

src/test/scala/PullRequestOpSpec.scala

@@ -33,7 +33,7 @@ class PullRequestOpSpec extends FunSpec with api.Constants {
   describe("getPullRequest") {
     it("with open PR should succeed") {
       val pr = Await.result(api.getPullRequest(otherUser, otherUserRepo, 21L), TIMEOUT)
-      assert(pr.size >= 0)
+      assert(pr.nonEmpty)
       assert(pr.exists(_.state == IssueState.closed))
       assert(pr.exists(_.mergeable == Some(false)))
       assert(pr.exists(_.merge_commit_sha.size == shaSize))

src/test/scala/PullRequestReviewOpSpec.scala

@@ -22,7 +22,7 @@ class PullRequestReviewOpSpec extends FunSpec with api.Constants {
   describe("getPullRequestReview") {
     it("with valid repo should succeed") {
       val review = Await.result(api.getPullRequestReview(otherUser, otherUserRepo, 47, 32477105), TIMEOUT)
-      assert(review.size >= 0)
+      assert(review.nonEmpty)
       assert(review.exists(_.id >= 0))
       assert(review.exists(_.state == PullRequestReviewState.approved))
       assert(review.exists(_.commit_id.size == shaSize))

src/test/scala/UserOpSpec.scala

@@ -15,7 +15,7 @@ class UserOpSpec extends FunSpec
 {
   val origin = Await.result(api.getAuthenticatedUser, TIMEOUT)
 
-  override def afterAll() {
+  override def afterAll(): Unit = {
     val input = UserInput(
       origin.name.orElse(Some("")),
       origin.email.orElse(Some("")),

src/test/scala/events/GitHubEventSpec.scala

@@ -32,7 +32,7 @@ class GitHubEventSpec extends FunSpec with Matchers with Inside
           describe("Issue") {
             val issue = e.issue
             it("should have a number") {
-              assert(issue.number === 2l)
+              assert(issue.number === 2L)
             }
             it("should have a title") {
               assert(issue.title === "Spelling error in the README file")
@@ -135,7 +135,7 @@ class GitHubEventSpec extends FunSpec with Matchers with Inside
             assert(name === "pull_request")
           }
           it("should have a number") {
-            assert(e.number === 1l)
+            assert(e.number === 1L)
           }
           it("should have an action") {
             assert(e.action === models.PullRequestAction.opened)
@@ -146,7 +146,7 @@ class GitHubEventSpec extends FunSpec with Matchers with Inside
           describe("PullRequest") {
             val pr = e.pull_request
             it("should have a number") {
-              assert(pr.number === 1l)
+              assert(pr.number === 1L)
             }
             it("should have a title") {
               assert(pr.title === "Update the README with new information")
@@ -208,7 +208,7 @@ class GitHubEventSpec extends FunSpec with Matchers with Inside
           describe("PullRequestReview") {
             val review = e.review
             it("should have an id") {
-              assert(review.id === 2626884l)
+              assert(review.id === 2626884L)
             }
             it("should have a state") {
               assert(review.state === models.PullRequestReviewState.approved)
@@ -224,7 +224,7 @@ class GitHubEventSpec extends FunSpec with Matchers with Inside
           describe("PullRequest") {
             val pr = e.pull_request
             it("should have a number") {
-              assert(pr.number === 8l)
+              assert(pr.number === 8L)
             }
             it("should have a title") {
               assert(pr.title === "Add a README description")
@@ -267,7 +267,7 @@ class GitHubEventSpec extends FunSpec with Matchers with Inside
           describe("Repository") {
             val repo = e.repository
             it("should have an id") {
-              assert(repo.id === 35129377l)
+              assert(repo.id === 35129377L)
             }
             it("should have a name") {
               assert(repo.name === "public-repo")
@@ -285,7 +285,7 @@ class GitHubEventSpec extends FunSpec with Matchers with Inside
           describe("User") {
             val user = e.sender
             it("should have an id") {
-              assert(user.id === 6752317l)
+              assert(user.id === 6752317L)
             }
             it("should have a login") {
               assert(user.login === "baxterthehacker")