Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remap Youtube Shortcuts? Keep visual feedback. (Display default YouTube icons and overwrite default shortcuts) #110

Closed
Mike-Correa opened this issue Oct 21, 2019 · 2 comments
Labels
Completion / Revision Rethink, complete, improve, tweak our feature or structure. good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@Mike-Correa
Copy link
Contributor

Functions like increase/decrease volume, seek forward/backward and increase/decrease playback speed have by default a set of icons that are displayed on screen when you use the default keyboard shortcuts for that. But using custom shortcuts from ImprovedTube 2.0 doesn't have the same effect. In fact no visual feedback is shown at all, so it's impossible to know at what speed the video is being reproduced, for example.

A nice fix for this would be to simply remap the default keyboard shortcuts, without changing the original behavior of the functions. This would ensure that the functions work as intended, with visual feedback being displayed, and also it would prevent double hotkeys and conflicting hotkeys, because currently, when a shortcut is created, the default shortcuts aren't disabled.

If it's not possible to remap the keys of the original fuctions, then disabling them when a custom key is added would be the best option. But the correct visual feedback is essential.

@ghost ghost added Bug Bug or required update after YouTube changes Feature request Wish or idea and removed Bug Bug or required update after YouTube changes labels Oct 21, 2019
@ImprovedTube ImprovedTube added the help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) label Dec 13, 2020
@ghost ghost removed the help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) label Dec 13, 2020
@ImprovedTube ImprovedTube added the Completion / Revision Rethink, complete, improve, tweak our feature or structure. label Feb 11, 2023
@ImprovedTube ImprovedTube added up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* labels Oct 19, 2023
@ImprovedTube ImprovedTube changed the title Display default YouTube icons and overwrite default shortcuts Remap Youtube Shortcuts? Keep visual feedback. (Display default YouTube icons and overwrite default shortcuts) Apr 5, 2024
@ImprovedTube ImprovedTube removed the Feature request Wish or idea label Apr 5, 2024
@ImprovedTube
Copy link
Member

thank you @Mike-Correa!

lets continue here #1565. #1566, etc

@raszpl
Copy link
Contributor

raszpl commented Jul 1, 2024

using custom shortcuts from ImprovedTube 2.0 doesn't have the same effect. In fact no visual feedback is shown at all, so it's impossible to know at what speed the video is being reproduced

implemented for some time

ImprovedTube.showStatus = function (value) {

this.showStatus(player.getVolume());

A nice fix for this would be to simply remap the default keyboard shortcuts, without changing the original behavior of the functions. This would ensure that the functions work as intended

redirecting shortcuts would be possible, Can you list something we are missing and should redirect?

with visual feedback being displayed,

we now have feedback, maybe not the prettiest one but it works :)

and also it would prevent double hotkeys and conflicting hotkeys, because currently, when a shortcut is created, the default shortcuts aren't disabled.

fixed, afaik all default YT shortcuts can be overridden disabling original ones

If it's not possible to remap the keys of the original fuctions, then disabling them when a custom key is added would be the best option. But the correct visual feedback is essential.

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completion / Revision Rethink, complete, improve, tweak our feature or structure. good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
None yet
Development

No branches or pull requests

3 participants