Skip to content

Issues: code-423n4/2024-03-pooltogether-findings

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear current search query, filters, and sorts
11 Open 219 Closed
11 Open 219 Closed
Author
Filter by author
Loading
Label
Filter by label
Loading
Use alt + click/return to exclude labels
or ⇧ + click/return for logical OR
Projects
Filter by project
Loading
Milestones
Filter by milestone
Loading
Assignee
Filter by who’s assigned
Sort
Sort by
Newest Oldest Most commented Least commented Recently updated Least recently updated Best match
Most reactions
👍 👎 😄 🎉 😕 ❤️ 🚀 👀

Issues list

QA Report bug Something isn't working grade-b insufficient quality report This report is not of sufficient quality Q-01 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
#346 opened Mar 11, 2024 by c4-bot-6
6
The winner can steal claimer fees, and force him to pay for the gas 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working insufficient quality report This report is not of sufficient quality M-01 primary issue Highest quality submission among a set of duplicates 🤖_78_group AI based duplicate group recommendation satisfactory satisfies C4 submission criteria; eligible for awards selected for report This submission will be included/highlighted in the audit report sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#345 opened Mar 11, 2024 by c4-bot-6
15
_maxYieldVaultWithdraw() uses yieldVault.convertToAssets() 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working insufficient quality report This report is not of sufficient quality M-02 primary issue Highest quality submission among a set of duplicates 🤖_66_group AI based duplicate group recommendation satisfactory satisfies C4 submission criteria; eligible for awards selected for report This submission will be included/highlighted in the audit report sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#336 opened Mar 11, 2024 by c4-bot-5
16
maxDeposit() uses yieldVault.maxDeposit() but _depositAndMint() uses yieldVault.mint() 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working insufficient quality report This report is not of sufficient quality M-03 primary issue Highest quality submission among a set of duplicates 🤖_66_group AI based duplicate group recommendation satisfactory satisfies C4 submission criteria; eligible for awards selected for report This submission will be included/highlighted in the audit report sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
#335 opened Mar 11, 2024 by c4-bot-10
17
Dust sweeping may exceed yield vault deposit limit bug Something isn't working downgraded by judge Judge downgraded the risk level of this issue grade-a insufficient quality report This report is not of sufficient quality primary issue Highest quality submission among a set of duplicates Q-02 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax 🤖_141_group AI based duplicate group recommendation satisfactory satisfies C4 submission criteria; eligible for awards
#333 opened Mar 11, 2024 by c4-bot-7
11
_withdraw() may attempt to withdraw more than available bug Something isn't working downgraded by judge Judge downgraded the risk level of this issue grade-a insufficient quality report This report is not of sufficient quality primary issue Highest quality submission among a set of duplicates QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax 🤖_90_group AI based duplicate group recommendation
#332 opened Mar 11, 2024 by c4-bot-7
11
QA Report bug Something isn't working grade-b insufficient quality report This report is not of sufficient quality Q-03 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
#250 opened Mar 11, 2024 by c4-bot-8
4
yieldFeeBalance wouldn't be claimed after calling transferTokensOut(). 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working insufficient quality report This report is not of sufficient quality M-05 🤖_188_group AI based duplicate group recommendation satisfactory satisfies C4 submission criteria; eligible for awards selected for report This submission will be included/highlighted in the audit report sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#244 opened Mar 11, 2024 by c4-bot-9
10
QA Report bug Something isn't working grade-b insufficient quality report This report is not of sufficient quality Q-06 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
#110 opened Mar 9, 2024 by c4-bot-8
4
PrizeVault.maxDeposit() doesn't take into account produced fees 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working insufficient quality report This report is not of sufficient quality M-07 primary issue Highest quality submission among a set of duplicates 🤖_66_group AI based duplicate group recommendation satisfactory satisfies C4 submission criteria; eligible for awards selected for report This submission will be included/highlighted in the audit report sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#91 opened Mar 8, 2024 by c4-bot-8
11
QA Report bug Something isn't working grade-b insufficient quality report This report is not of sufficient quality Q-07 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
#53 opened Mar 8, 2024 by c4-bot-2
4
ProTip! Type g p on any issue or pull request to go back to the pull request listing page.