Skip to content

Issues: code-423n4/2023-09-centrifuge-findings

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Author
Filter by author
Loading
Label
Filter by label
Loading
Use alt + click/return to exclude labels
or + click/return for logical OR
Projects
Filter by project
Loading
Milestones
Filter by milestone
Loading
Assignee
Filter by who’s assigned
Sort

Issues list

QA Report bug Something isn't working grade-a Q-01 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sufficient quality report This report is of sufficient quality
#784 opened Sep 14, 2023 by c4-submissions
The Restriction Manager does not completely implement ERC1404 which leads to account that are supposed to be restricted actually have access to do with their tokens as they see fit 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working low quality report This report is of especially low quality M-01 primary issue Highest quality submission among a set of duplicates satisfactory satisfies C4 submission criteria; eligible for awards selected for report This submission will be included/highlighted in the audit report
#779 opened Sep 14, 2023 by c4-submissions
User's tokens can get locked in UserEscrow.sol for an unknown duration of time... potentially forever. bug Something isn't working downgraded by judge Judge downgraded the risk level of this issue duplicate-32 grade-a QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sufficient quality report This report is of sufficient quality
#773 opened Sep 14, 2023 by c4-submissions
QA Report bug Something isn't working grade-b Q-02 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sufficient quality report This report is of sufficient quality
#770 opened Sep 14, 2023 by c4-submissions
QA Report bug Something isn't working grade-b Q-03 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sufficient quality report This report is of sufficient quality
#767 opened Sep 14, 2023 by c4-submissions
QA Report bug Something isn't working edited-by-warden grade-b Q-04 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sufficient quality report This report is of sufficient quality
#765 opened Sep 14, 2023 by c4-submissions
Wards cannot intervene on liquidity pools bug Something isn't working downgraded by judge Judge downgraded the risk level of this issue duplicate-41 grade-b low quality report This report is of especially low quality Q-05 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
#761 opened Sep 14, 2023 by c4-submissions
permit and _isValidSignature would fail to validate signatures from counterfactual wallets bug Something isn't working downgraded by judge Judge downgraded the risk level of this issue grade-a QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sufficient quality report This report is of sufficient quality unsatisfactory does not satisfy C4 submission criteria; not eligible for awards
#760 opened Sep 14, 2023 by c4-submissions
PoolManager assumes only one EVM address exists for all currencies bug Something isn't working downgraded by judge Judge downgraded the risk level of this issue duplicate-477 grade-a QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sufficient quality report This report is of sufficient quality
#751 opened Sep 14, 2023 by c4-submissions
QA Report bug Something isn't working grade-b Q-07 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sufficient quality report This report is of sufficient quality
#740 opened Sep 14, 2023 by c4-submissions
QA Report bug Something isn't working grade-b Q-08 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sufficient quality report This report is of sufficient quality
#663 opened Sep 14, 2023 by c4-submissions
destination address can't actually call transferOut() of UserEscrow.sol bug Something isn't working downgraded by judge Judge downgraded the risk level of this issue grade-b primary issue Highest quality submission among a set of duplicates Q-09 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sufficient quality report This report is of sufficient quality
#653 opened Sep 14, 2023 by c4-submissions
withApproval modifier is not working as expected bug Something isn't working downgraded by judge Judge downgraded the risk level of this issue duplicate-41 grade-b low quality report This report is of especially low quality Q-10 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
#649 opened Sep 14, 2023 by c4-submissions
QA Report bug Something isn't working grade-b Q-11 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sufficient quality report This report is of sufficient quality
#642 opened Sep 14, 2023 by c4-submissions
QA Report bug Something isn't working grade-b Q-12 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sufficient quality report This report is of sufficient quality
#636 opened Sep 14, 2023 by c4-submissions
QA Report bug Something isn't working grade-b Q-13 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sufficient quality report This report is of sufficient quality
#626 opened Sep 14, 2023 by c4-submissions
QA Report bug Something isn't working grade-b Q-14 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sufficient quality report This report is of sufficient quality
#606 opened Sep 14, 2023 by c4-submissions
QA Report bug Something isn't working grade-b Q-15 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sufficient quality report This report is of sufficient quality
#597 opened Sep 14, 2023 by c4-submissions
QA Report bug Something isn't working grade-b Q-16 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sufficient quality report This report is of sufficient quality
#585 opened Sep 14, 2023 by c4-submissions
[M-05] LiquidityPool.withApproval(): Wards not checked, not allowing authorized admin to call functions bug Something isn't working downgraded by judge Judge downgraded the risk level of this issue duplicate-41 grade-b low quality report This report is of especially low quality Q-17 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
#559 opened Sep 14, 2023 by c4-submissions
QA Report bug Something isn't working grade-a high quality report This report is of especially high quality Q-18 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax selected for report This submission will be included/highlighted in the audit report sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#548 opened Sep 14, 2023 by c4-submissions
QA Report bug Something isn't working grade-b Q-19 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sufficient quality report This report is of sufficient quality
#545 opened Sep 14, 2023 by c4-submissions
onlyCentrifugeChainOrigin() can't require msg.sender equal axelarGateway 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working downgraded by judge Judge downgraded the risk level of this issue high quality report This report is of especially high quality M-02 primary issue Highest quality submission among a set of duplicates satisfactory satisfies C4 submission criteria; eligible for awards selected for report This submission will be included/highlighted in the audit report sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#537 opened Sep 14, 2023 by c4-submissions
Complete halt under certain circumstances bug Something isn't working disagree with severity Sponsor confirms validity, but disagrees with warden’s risk assessment (sponsor explain in comments) downgraded by judge Judge downgraded the risk level of this issue grade-b Q-20 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons sufficient quality report This report is of sufficient quality
#509 opened Sep 14, 2023 by c4-submissions
QA Report bug Something isn't working grade-b Q-21 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sufficient quality report This report is of sufficient quality
#475 opened Sep 14, 2023 by c4-submissions
ProTip! no:milestone will show everything without a milestone.