From 7124a934942b95a59cab019e222e2415750402bb Mon Sep 17 00:00:00 2001 From: C4 <81770958+code423n4@users.noreply.github.com> Date: Sun, 18 Sep 2022 08:37:11 +0200 Subject: [PATCH] Report for issue #106 updated by RaymondFam --- data/RaymondFam-Q.md | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/data/RaymondFam-Q.md b/data/RaymondFam-Q.md index 9fa6a81..9c3d70f 100644 --- a/data/RaymondFam-Q.md +++ b/data/RaymondFam-Q.md @@ -1,4 +1,16 @@ ## Un-indexed Parameters in Events Consider indexing parameters for events, serving as logs filter when looking for specifically wanted data. Up to three parameters in an event function can receive the attribute indexed which will cause the respective arguments to be treated as log topics instead of data. The following links are some of the instances entailed: -https://github.com/code-423n4/2022-09-y2k-finance/blob/main/src/Controller.sol#L49-L56 \ No newline at end of file +https://github.com/code-423n4/2022-09-y2k-finance/blob/main/src/Controller.sol#L49-L56 + +## Unused State Variable +https://github.com/code-423n4/2022-09-y2k-finance/blob/main/src/oracles/PegOracle.sol#L13 + +The state variable `decimals` has been assigned `priceFeed1.decimals()` in the constructor, but it is never used in the contract. It could have been used in the following line of code such that: + +https://github.com/code-423n4/2022-09-y2k-finance/blob/main/src/oracles/PegOracle.sol#L73 + +``` + int256 decimals10 = int256(10**(18 - decimals); +``` +