From bbf38174c04384243548b4085642031b752668d4 Mon Sep 17 00:00:00 2001 From: C4 <81770958+code423n4@users.noreply.github.com> Date: Sat, 17 Sep 2022 22:54:57 +0200 Subject: [PATCH] Matin data for issue #124 --- data/Matin-G.md | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 data/Matin-G.md diff --git a/data/Matin-G.md b/data/Matin-G.md new file mode 100644 index 0000000..0c2ad29 --- /dev/null +++ b/data/Matin-G.md @@ -0,0 +1,11 @@ +1- Setting uint256 to its default value which is zero is redundant (for example): +https://github.com/PartyDAO/party-contracts-c4/blob/main/contracts/party/PartyGovernance.sol#L306 +https://github.com/PartyDAO/party-contracts-c4/blob/main/contracts/distribution/TokenDistributor.sol#L230 +https://github.com/PartyDAO/party-contracts-c4/blob/main/contracts/distribution/TokenDistributor.sol#L239 +https://github.com/PartyDAO/party-contracts-c4/blob/main/contracts/crowdfund/Crowdfund.sol#L180 + + +2- Caching length in for loops. It's better to save the length outside the loop to save gas (for example): +https://github.com/PartyDAO/party-contracts-c4/blob/main/contracts/crowdfund/Crowdfund.sol#L180 +https://github.com/PartyDAO/party-contracts-c4/blob/main/contracts/crowdfund/Crowdfund.sol#L300 +https://github.com/PartyDAO/party-contracts-c4/blob/main/contracts/distribution/TokenDistributor.sol#L230