Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded value? #4330

Open
epicfaace opened this issue Dec 8, 2022 · 4 comments
Open

Hardcoded value? #4330

epicfaace opened this issue Dec 8, 2022 · 4 comments
Assignees
Labels
p2 Do it this quarter.

Comments

@epicfaace
Copy link
Member

Do we need to change this? @AndrewJGaut

return f"ws://ws-server:{ws_port}"

@AndrewJGaut
Copy link
Contributor

I thought that the host name would always be the service name (similar to how it is in the Docker compose file here https://github.com/codalab/codalab-worksheets/blob/master/docker_config/compose_files/docker-compose.yml#L458), but I can fix this. Sorry about that!

@percyliang percyliang added the p2 Do it this quarter. label Sep 24, 2023
@percyliang
Copy link
Collaborator

What do we need to do here?

@AndrewJGaut
Copy link
Contributor

@epicfaace Can you remind me what the issue is here? Is it that we should use the passed in value here rather than getting the address from code in the CodalabManager?

@epicfaace
Copy link
Member Author

Yeah, I think that's right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2 Do it this quarter.
Projects
None yet
Development

No branches or pull requests

3 participants