Skip to content

Commit b26e1bb

Browse files
authored
correct #18768, add check for unsafe strcpy() (#18885)
* add check for unsafe strcpy() add check for unsafe strcpy() * complying with required coding style substitute tab with 4 spaces * NULL -> nullptr
1 parent 702fc83 commit b26e1bb

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

cocos/scripting/lua-bindings/manual/network/lua_xml_http_request.cpp

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -266,15 +266,18 @@ void LuaMinXmlHttpRequest::_setHttpRequestHeader()
266266
const char* second = it->second.c_str();
267267
size_t len = sizeof(char) * (strlen(first) + 3 + strlen(second));
268268
char* test = (char*) malloc(len);
269-
memset(test, 0,len);
269+
if (test != nullptr) //should check failure of malloc or it could be an undefined behaviour
270+
{
271+
memset(test, 0,len);
270272

271-
strcpy(test, first);
272-
strcpy(test + strlen(first) , ": ");
273-
strcpy(test + strlen(first) + 2, second);
273+
strcpy(test, first);
274+
strcpy(test + strlen(first) , ": ");
275+
strcpy(test + strlen(first) + 2, second);
274276

275-
header.push_back(test);
277+
header.push_back(test);
276278

277-
free(test);
279+
free(test);
280+
}
278281

279282
}
280283

0 commit comments

Comments
 (0)