Skip to content

build: min supported version is go 1.23 #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2025

Conversation

dhartunian
Copy link
Contributor

@dhartunian dhartunian commented May 2, 2025

The minimum version that we test with is now 1.23 which modifies some
stacktrace output. This is done so tests can pass reliably.

Due to the dependency bump, we cannot continue to support go versions
below 1.23 moving forward.

Resolves: CRDB-49975

This change is Reviewable

@dhartunian dhartunian force-pushed the davidh/push-nzwovrxnkxmz branch 3 times, most recently from b308a10 to 5c77cc1 Compare May 2, 2025 16:21
The minimum version that we test with is now 1.23 which modifies some
stacktrace output. This is done so tests can pass reliably.

Due to the dependency bump, we cannot continue to support go versions
below 1.23 moving forward.

Resolves: CRDB-49975
@dhartunian dhartunian force-pushed the davidh/push-nzwovrxnkxmz branch from 5c77cc1 to 766aa4d Compare May 2, 2025 16:26
@dhartunian dhartunian changed the title ci: add more go versions to builds build: min supported version is go 1.23 May 2, 2025
@dhartunian
Copy link
Contributor Author

I will release version 1.12.0 of this library once this PR merges.

@dhartunian dhartunian merged commit 2008f7c into cockroachdb:master May 2, 2025
5 checks passed
@dhartunian dhartunian deleted the davidh/push-nzwovrxnkxmz branch May 2, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants