Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cockroachdb/cockroachdb-parser
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: cockroachdb/cockroachdb-parser
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: jeffswenson-update-grpc-gateway
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 4 files changed
  • 1 contributor

Commits on Aug 28, 2023

  1. go.mod: update grpc-gateway to v2 

    Attempting to build grpc-gateway v1 using the latest version of
io_bazel_go_rules fails due to a breaking change in how
io_bazel_go_rules resolves googleapi protobufs
(https://github.com/bazelbuild/rules_go/releases/tag/v0.41.0).

Version v2.15.2 was chosen because it is a relatively recent version
that occurs before the breaking change was fixed in grpc-gateway. This
allows cockroachdb to import the change without bumping the
io_bazel_rules_go version. Other repositories that want to bump their
io_bazel_rules_go can explicitly depend on a version of grpc-gatewy that
includes the bazel fix.
    @jeffswenson
    jeffswenson committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    04c2181 View commit details
    Browse the repository at this point in the history
Loading