release-21.2: server: add basic TLS support to tenant HTTP server #70056
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #69723 on behalf of @dhartunian.
/cc @cockroachdb/release
Previously, the tenant HTTP server only served non-TLS connections by
default. This change will use the TLS config when it's present and serve
the HTTP server over TLS on the tenant. As on dedicated nodes, the
configuration will pick up the optional UI cert or the node cert as a
fallback.
This change also adds TLS to all other HTTP servers on the tenant server
including the
_status/vars
endpoint andpprof
endpoints.Resolves #69927
Release justification: fixing high-priority bug in existing
functionality.
Release note (security update): sql tenant servers will now use a TLS
certificate for their HTTP server when it's present. Previously this
server never used TLS.
Release justification: This change is necessary to support TLS for HTTP on tenant instances. It will only be enabled for tenants running in secure mode. No changes to kv nodes are made in this PR.