Skip to content

Revert DEPS: upgrade grpc to v1.57.2 #138283 #139038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

tbg
Copy link
Member

@tbg tbg commented Jan 14, 2025

This effectively reverts #138283.
That PR causes build failures. Revert while we find out.

Epic: None
Release note: None

@tbg tbg requested review from a team as code owners January 14, 2025 16:22
@tbg tbg requested review from dhartunian and removed request for a team January 14, 2025 16:22
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@tbg tbg changed the title Revert "DEPS: add resolve hints and update packages" Revert DEPS: upgrade grpc to v1.57.2 #138283 Jan 14, 2025
Copy link
Collaborator

@fqazi fqazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @dhartunian)

@tbg
Copy link
Member Author

tbg commented Jan 14, 2025

bors r+
TFTR!

@tbg
Copy link
Member Author

tbg commented Jan 14, 2025

bors single on

@tbg
Copy link
Member Author

tbg commented Jan 14, 2025

bors p=999

@tbg
Copy link
Member Author

tbg commented Jan 14, 2025

bors r-

Figured it out I think

@craig
Copy link
Contributor

craig bot commented Jan 14, 2025

Canceled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants