Skip to content

builtins: implement to_char(date, string) #102787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2023

Conversation

otan
Copy link
Contributor

@otan otan commented May 5, 2023

Release note (sql change): Introduce the to_char(date, format) builtin variant, which converts a given date to a string using the given format string.

Informs #3781

(if we had implicit casts this wouldnt be an issue!)

@otan otan added backport-22.1.x backport-23.1.x Flags PRs that need to be backported to 23.1 labels May 5, 2023
@otan otan requested review from rafiss and a team May 5, 2023 02:34
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@otan otan force-pushed the master branch 2 times, most recently from 1c6b711 to 9bdddd5 Compare May 7, 2023 22:41
Release note (sql change): Introduce the `to_char(date, format)` builtin
variant, which converts a given date to a string using the given format
string.
@otan
Copy link
Contributor Author

otan commented May 10, 2023

bors r=rafiss

@craig
Copy link
Contributor

craig bot commented May 10, 2023

Build succeeded:

@craig craig bot merged commit 245c3b9 into cockroachdb:master May 10, 2023
@blathers-crl
Copy link

blathers-crl bot commented May 10, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 7a4bbaa to blathers/backport-release-22.2-102787: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.2.x failed. See errors above.


error creating merge commit from 7a4bbaa to blathers/backport-release-23.1-102787: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants