Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: make protobuf requires internet access #17752

Closed
a-robinson opened this issue Aug 18, 2017 · 2 comments
Closed

build: make protobuf requires internet access #17752

a-robinson opened this issue Aug 18, 2017 · 2 comments

Comments

@a-robinson
Copy link
Contributor

It's hardly the end of the world, but is there an easy way to make building our protocol buffers not require internet access? If I change a proto (e.g. by adding a new enum value to storage/log.proto) and try to run make protobuf without being connected to the internet, it always hangs on an npm command:

⸨░░░░░░░░░░░░░░░░░░⸩ ⠧ normalizeTree: sill install loadCurrentTree

I also got it hung in this other place once when I disconnected from the internet while make protobuf was in the middle of running:

⸨    ░░░░░░░░░░░░░░⸩ ⠴ fetchMetadata: sill mapToRegistry uri https://registry.npmjs.org/taffydb
⸨    ░░░░░░░░░░░░░░⸩ ⠇ fetchMetadata: verb afterAdd /Users/alex/.npm/marked/0.3.6/package/package.json written

Connecting to the internet fixes things. I don't remember it having always been this way.

cc @cockroachdb/build

@benesch
Copy link
Contributor

benesch commented Aug 18, 2017

I'm pretty sure this is due to a bug in protobuf.js (protobufjs/protobuf.js#716). We very intentionally run yarn install, which will avoid hitting the network if all deps are satisfied, but pbjs runs npm install behind our back, which I assume hits the network for something. It's pretty terrible.

@a-robinson
Copy link
Contributor Author

This works for me now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants