Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crosscluster/logical: check NOT NULL and DEFAULT value on the kv write path #134570

Open
msbutler opened this issue Nov 7, 2024 · 1 comment
Open
Assignees
Labels
A-disaster-recovery C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) P-2 Issues/test failures with a fix SLA of 3 months T-disaster-recovery

Comments

@msbutler
Copy link
Collaborator

msbutler commented Nov 7, 2024

Currently the kv write path does not recheck that a replicating row abides by the destination table's DEFAULT and NOT NULL constraints. That being said, since LDR only supports single column family tables & tables with identical schema, then the replicating row already passed the identical check on the source side. So, it really isn't a big deal to skip replicating check constraints on the kv write path. We'd like to add this checks as we want the kv and sql paths to eventually converge.

Jira issue: CRDB-44147

@msbutler msbutler added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-disaster-recovery labels Nov 7, 2024
Copy link

blathers-crl bot commented Nov 7, 2024

cc @cockroachdb/disaster-recovery

@exalate-issue-sync exalate-issue-sync bot added the P-2 Issues/test failures with a fix SLA of 3 months label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-disaster-recovery C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) P-2 Issues/test failures with a fix SLA of 3 months T-disaster-recovery
Projects
None yet
Development

No branches or pull requests

2 participants