Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

admission: indexBackfiller should be subject to elastic CPU control #115421

Open
sumeerbhola opened this issue Dec 1, 2023 · 0 comments
Open

admission: indexBackfiller should be subject to elastic CPU control #115421

sumeerbhola opened this issue Dec 1, 2023 · 0 comments
Labels
A-admission-control C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-23.2-scale-testing issues found during 23.2 scale testing O-testcluster Issues found or occurred on a test cluster, i.e. a long-running internal cluster T-admission-control Admission Control

Comments

@sumeerbhola
Copy link
Collaborator

sumeerbhola commented Dec 1, 2023 •
edited by cockroach-jira-scripts
Loading

It is already considered elastic work wrt store writes, so considering it the same wrt CPU is consistent.

This is the profile mentioned in https://cockroachlabs.slack.com/archives/C067NG669KJ/p1701397203699929?thread_ts=1701395533.260899&cid=C067NG669KJ. Making this change may be hard -- some of this CPU happens in:

  • grpc when sending the addSSTable
  • building the index entries in the context of a transaction (in the client). We may not want to prolong how long the (read-only?) transaction needs to stay open.
Screenshot 2023-12-01 at 9 01 53 AM

Jira issue: CRDB-34024
@sumeerbhola sumeerbhola added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-admission-control labels Dec 1, 2023
@williamkulju williamkulju added O-23.2-scale-testing issues found during 23.2 scale testing O-testcluster Issues found or occurred on a test cluster, i.e. a long-running internal cluster labels Dec 4, 2023
@nicktrav nicktrav added the T-admission-control Admission Control label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-admission-control C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-23.2-scale-testing issues found during 23.2 scale testing O-testcluster Issues found or occurred on a test cluster, i.e. a long-running internal cluster T-admission-control Admission Control
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nicktrav @sumeerbhola @williamkulju