kvserverpb: remove Equal from ReplicatedEvalResult

We can compare it directly since we only ever wanted to
compare it to zero.

Release note: None

Author: tbg

pkg/kv/kvserver/batcheval/result/result.go

@@ -164,7 +164,7 @@ func (p *Result) IsZero() bool {
 	if !p.Local.IsZero() {
 		return false
 	}
-	if !p.Replicated.Equal(kvserverpb.ReplicatedEvalResult{}) {
+	if !p.Replicated.IsZero() {
 		return false
 	}
 	if p.WriteBatch != nil {

pkg/kv/kvserver/kvserverpb/proposer_kv.go

@@ -21,3 +21,8 @@ var maxRaftCommandFooterSize = (&RaftCommandFooter{
 func MaxRaftCommandFooterSize() int {
 	return maxRaftCommandFooterSize
 }
+
+// IsZero returns whether all fields are set to their zero value.
+func (r ReplicatedEvalResult) IsZero() bool {
+	return r == ReplicatedEvalResult{}
+}

pkg/kv/kvserver/kvserverpb/proposer_kv.pb.go

@@ -50,8 +50,6 @@ message Merge {
 // ChangeReplicas is emitted by a Replica which commits a transaction with
 // a ChangeReplicasTrigger.
 message ChangeReplicas {
-  option (gogoproto.equal) = true;
-
   option (gogoproto.goproto_stringer) = false;
 
   roachpb.ChangeReplicasTrigger trigger = 1 [(gogoproto.nullable) = false,
@@ -117,8 +115,6 @@ message SuggestedCompaction {
 // leases, log truncation, ...) of the Replica or certain special commands must
 // sideline information here based on which all Replicas must take action.
 message ReplicatedEvalResult {
-  option (gogoproto.equal) = true;
-
   // Updates to the Replica's ReplicaState. By convention and as outlined on
   // the comment on the ReplicaState message, this field is sparsely populated
   // and any field set overwrites the corresponding field in the state, perhaps

pkg/kv/kvserver/kvserverpb/proposer_kv.proto

@@ -70,7 +70,7 @@ func isTrivial(r *kvserverpb.ReplicatedEvalResult) bool {
 	allowlist.DeprecatedDelta = nil
 	allowlist.PrevLeaseProposal = nil
 	allowlist.State = nil
-	return allowlist.Equal(kvserverpb.ReplicatedEvalResult{})
+	return allowlist.IsZero()
 }
 
 // clearTrivialReplicatedEvalResultFields is used to zero out the fields of a

pkg/kv/kvserver/replica_application_result.go

@@ -1070,7 +1070,7 @@ func (sm *replicaStateMachine) ApplySideEffects(
 			sm.r.mu.Unlock()
 			sm.stats.stateAssertions++
 		}
-	} else if res := cmd.replicatedResult(); !res.Equal(kvserverpb.ReplicatedEvalResult{}) {
+	} else if res := cmd.replicatedResult(); !res.IsZero() {
 		log.Fatalf(ctx, "failed to handle all side-effects of ReplicatedEvalResult: %v", res)
 	}
 
@@ -1126,7 +1126,7 @@ func (sm *replicaStateMachine) handleNonTrivialReplicatedEvalResult(
 	ctx context.Context, rResult *kvserverpb.ReplicatedEvalResult,
 ) (shouldAssert, isRemoved bool) {
 	// Assert that this replicatedResult implies at least one side-effect.
-	if rResult.Equal(kvserverpb.ReplicatedEvalResult{}) {
+	if rResult.IsZero() {
 		log.Fatalf(ctx, "zero-value ReplicatedEvalResult passed to handleNonTrivialReplicatedEvalResult")
 	}
 
@@ -1159,7 +1159,7 @@ func (sm *replicaStateMachine) handleNonTrivialReplicatedEvalResult(
 	// The rest of the actions are "nontrivial" and may have large effects on the
 	// in-memory and on-disk ReplicaStates. If any of these actions are present,
 	// we want to assert that these two states do not diverge.
-	shouldAssert = !rResult.Equal(kvserverpb.ReplicatedEvalResult{})
+	shouldAssert = !rResult.IsZero()
 	if !shouldAssert {
 		return false, false
 	}
@@ -1200,7 +1200,7 @@ func (sm *replicaStateMachine) handleNonTrivialReplicatedEvalResult(
 		rResult.ComputeChecksum = nil
 	}
 
-	if !rResult.Equal(kvserverpb.ReplicatedEvalResult{}) {
+	if !rResult.IsZero() {
 		log.Fatalf(ctx, "unhandled field in ReplicatedEvalResult: %s", pretty.Diff(rResult, kvserverpb.ReplicatedEvalResult{}))
 	}
 	return true, isRemoved

pkg/kv/kvserver/replica_application_state_machine.go

@@ -777,7 +777,7 @@ func (r *Replica) evaluateProposal(
 	// 3. the request has replicated side-effects.
 	needConsensus := !batch.Empty() ||
 		ms != (enginepb.MVCCStats{}) ||
-		!res.Replicated.Equal(kvserverpb.ReplicatedEvalResult{})
+		!res.Replicated.IsZero()
 
 	if needConsensus {
 		// Set the proposal's WriteBatch, which is the serialized representation of