Skip to content

add: linear search implementation (+ benchmarks) #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dhartunian
Copy link

@dhartunian dhartunian commented Jan 23, 2025

This is a cherry-pick of a histogram bucket lookup optimization on master

Original PR: prometheus#1673
Which was discussed in more detail in a prior iteration here:
prometheus#1662

Part of cockroachdb/cockroach#133306

@dhartunian dhartunian changed the title histogram: expose FindBucket in Histogram API add: linear search implementation (+ benchmarks) Jan 23, 2025
Copy link

@kyle-a-wong kyle-a-wong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can you include a link to the original cherry-picked commit / PR in the prometheus/client_golang repo?

otherwise, LGTM

Original PR: prometheus#1673
Which was discussed in more detail in a prior iteration here:
prometheus#1662

Signed-off-by: Ivan Goncharov <i.morph@gmail.com>
@dhartunian dhartunian force-pushed the open-up-histogram-api-1.16.0-apply-perf-improvement branch from 23f5a64 to 27174d5 Compare January 24, 2025 16:18
@dhartunian dhartunian merged commit 2d4b7d3 into v1.16.0-crdb-changes Jan 24, 2025
@dhartunian dhartunian deleted the open-up-histogram-api-1.16.0-apply-perf-improvement branch January 24, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants