"Select faces by view angle" "Get" button gets normal instead of position

[nh2]

In Select faces by view angle:

in the ViewPoint column there is a Get button.

But it doesn't, as expected, fill in the current position of the camera into ViewPoint; instead, it fills in the current view angle as a normal.

I think this doesn't make sense, because the filter quite evidently operates on the thing in ViewPoint being a position. This can be easily checked by just scaling the values that "Get" puts in by a constant, and observing that different faces are selected.

I think the Get button should fill in the position.

[nh2]

Suspicion:

meshlab/src/meshlabplugins/filter_select/meshselect.cpp

Lines 301 to 305 in cac36d7

	parlst.addParam(RichDirection(
	"viewpoint",
	Point3f(0.0f, 0.0f, 0.0f),
	"ViewPoint",
	"if UseCamera is true, this value is ignored"));

should not be RichDirection but RichPosition.

[nh2]

I suspect that this is a regression introduced by:

8b490fc#diff-538cc8d0524f530596db0ca99c1cc74552152a1b1fd584a324524383804008adR185

from PR #1084

[alemuntoni]

Yes, you are right. When introducing the distinction between direction and position parameters, I just set the wrong parameter type for that filter. Sorry about that!
And thanks for the PR!!

[nh2]

Currently testing, will submit a PR in a moment.

[nh2]

Yes, the fix works. PR: #1208