Skip to content

Mention smoothed fb-survey signals closer to raw signal discussion #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 10, 2020

Conversation

capnrefsmmat
Copy link
Contributor

Raw signals are not listed for the other indicators, so we only need this comment for the CLI/ILI signals.

cc @dshemetov, who couldn't find the information he needed because of this issue.

Raw signals are not listed for the other indicators, so we only need
this comment for the CLI/ILI signals.
Copy link
Contributor

@Akvannortwick Akvannortwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but I would keep the Smoothing sub-header.

@capnrefsmmat
Copy link
Contributor Author

@Akvannortwick Do you mean on the paragraph beginning "The signals beginning with smoothed_"?

@Akvannortwick
Copy link
Contributor

Akvannortwick commented Nov 9, 2020

Yes, I feel it gives a nice separation in the text that doesn't affect flow. It's more personal preference, though there is no issue without it. @capnrefsmmat

@capnrefsmmat capnrefsmmat merged commit 0e2dd12 into main Nov 10, 2020
@krivard krivard deleted the docs/smoothed-signals branch November 18, 2020 14:39
sgratzl added a commit that referenced this pull request Jan 5, 2022
@sgratzl sgratzl mentioned this pull request Jan 5, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants