nssp documentation draft #1439

dsweber2 · 2024-05-17T04:34:56Z

Summary:

This adds documentation for NSSP

Prerequisites:

Unless it is a documentation hotfix it should be merged against the dev branch
Branch is up-to-date with the branch to be merged with, i.e. dev
Build is successful
[NA] Code is cleaned up and formatted

nmdefries

More detail needed for a couple topics. @minhkhul is probably the best person for some of them.

I moved stuff around and reworded some things, so please look over my changes.

docs/Gemfile.lock

docs/api/covidcast-signals/nssp.md

nmdefries · 2024-06-06T15:53:28Z

docs/api/covidcast-signals/nssp.md

+This data source has frequent backfill, primarily arising from newly included EDs. When a new facility joins the reporting network, its historical data is added to the dataset, resulting in changes to historical values for every geographic level that ED is part of (county through nation). Because of this, the broadest geographic levels are more likely to be revised.
+
+In previous revisions, we have noted changes to values dating back about 2 years.


suggestion: ideally, we'd have more detail here. For example,

how often do revisions happen?

how often are new facilities added?

are there any patterns to where new facilities are added?

how much do values change as a result?

@minhkhul

Do we have a similar revision analysis posted on the other sources? I don't ever remember seeing them. I agree it would be useful, but that sounds more like an overall doc overhaul thing

We have this type of info for some sources. It's something that Roni has requested more detail about recently and that we've wanted info about for various signals at various points in time.

I don't think this is critical to add now, but it will be easiest, since we've done the statistical analysis recently. I was hoping that @minhkhul or you had come across info about this during the analysis.

Questions about are some things that came to mind but are more guiding questions for the type of detail I'd be looking for. They don't all need to be answered exactly, but any additional info would be helpful.

Ultimately, this is up to y'all.

docs/api/covidcast-signals/nssp.md

nmdefries · 2024-06-06T16:00:07Z

@tinatownes do you see anything here that is missing compared to the source doc pages?

nmdefries · 2024-06-06T16:25:20Z

docs/api/covidcast-signals/nssp.md

+|---------------------------------|-------------------------------------------------------------------------|
+| `pct_visits_covid`              | Percent of ED visits that had a discharge diagnosis code of covid              |
+| `pct_visits_influenza`          | Percent of ED visits that had a discharge diagnosis code of influenza          |
+| `pct_visits_rsv`                | Percent of ED visits that had a discharge diagnosis code of rsv                |


suggestion: this is late in the game, so optional change, but signal names would be clearer as pct_er_visits_*

pct_ed_visits_*? I'm still not sure about the difference tbh. I'd leave it up to Minh, as she'd have the most to change.

I was considering "ed", but it's not how laypeople refer to it. As far as I'm aware, only healthcare workers call the ER the "ED". So I think for a more general audience, "er" is clearer, although it does differ from the dataset name.

Will ask Roni

@nmdefries, sorry I'm late here!

Minor suggestion: In the TOC, consider adding a link to the "Overview" to maintain consistency with the TOCs of signals such as "Change Healthcare" and "Doctor Visits".

Nothing else stands out, the headings are great. Thanks!

thanks for looking! Though I don't really follow what you mean. When I look at the table of contents in doctor-visits:

delphi-epidata/docs/api/covidcast-signals/doctor-visits.md

Lines 30 to 36 in e423cb4

## Table of Contents

{: .no_toc .text-delta}

1. TOC

{:toc}

## Estimation

it seems just the same as what's here?

delphi-epidata/docs/api/covidcast-signals/nssp.md

Lines 35 to 40 in 28482cf

## Table of contents

{: .no_toc .text-delta}

1. TOC

{:toc}

Waiting for a response from Roni about naming

@dsweber2 sorry for the confusion: you can prob just ignore my comment! I think the "Overview" section I'm pointing to may be contained in the {:toc} . Here's a visual where in doctor's visits the TOC has "Overview" circled in red:

Thanks!

Co-authored-by: nmdefries <42820733+nmdefries@users.noreply.github.com>

nmdefries · 2024-06-06T22:05:34Z

docs/api/covidcast-signals/nssp.md

+
+## Missingness
+
+As of May 2024, NSSP received data from 78% of US EDs.


Do we have a link for this number?

it's on the very bottom of the main NSSP index. Felt a little redundant linking to it again, but could definitely include

docs/api/covidcast-signals/nssp.md

minhkhul

Looks good!

nmdefries

From Roni, let's rename the signals by prefixing "visits" with "ed", e.g. pct_visits_covid to pct_ed_visits_covid.

This is ready to go whenever that is finished.

docs/api/covidcast-signals/nssp.md

nmdefries

🎉

sonarcloud · 2024-06-25T17:40:37Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

nssp documentation draft

af3a96b

dsweber2 requested a review from minhkhul May 17, 2024 04:35

nmdefries self-requested a review June 4, 2024 17:50

nmdefries added 3 commits June 5, 2024 18:14

limitations detail and wording improvements

dc918b6

limitations detail

a65a808

lag and backfill details

0d1d2a2

nmdefries requested changes Jun 6, 2024

View reviewed changes

nmdefries reviewed Jun 6, 2024

View reviewed changes

dsweber2 and others added 2 commits June 6, 2024 11:34

don't update Gem by hand

6a3eadd

include national data

fff0654

Co-authored-by: nmdefries <42820733+nmdefries@users.noreply.github.com>

nmdefries reviewed Jun 6, 2024

View reviewed changes

nmdefries added 2 commits June 6, 2024 18:15

missingness detail

761a808

move limitations down

889abe1

nmdefries reviewed Jun 6, 2024

View reviewed changes

docs/api/covidcast-signals/nssp.md Show resolved Hide resolved

nmdefries reviewed Jun 6, 2024

View reviewed changes

docs/api/covidcast-signals/nssp.md Outdated Show resolved Hide resolved

nmdefries and others added 2 commits June 6, 2024 18:27

Merge branch 'dev' into nsspDocs

6360508

earliest dates, checked states missing Counties

2a45528

minhkhul previously approved these changes Jun 7, 2024

View reviewed changes

earliest issue from Minh

28482cf

dsweber2 dismissed minhkhul’s stale review via 28482cf June 7, 2024 18:04

dsweber2 mentioned this pull request Jun 7, 2024

Universal Revision analysis #1474

Open

nmdefries previously approved these changes Jun 10, 2024

View reviewed changes

nmdefries reviewed Jun 10, 2024

View reviewed changes

docs/api/covidcast-signals/nssp.md Outdated Show resolved Hide resolved

adding ed, right source

a028cbe

dsweber2 dismissed nmdefries’s stale review via a028cbe June 25, 2024 16:09

nmdefries self-requested a review June 25, 2024 16:42

nmdefries previously approved these changes Jun 25, 2024

View reviewed changes

nmdefries added 2 commits June 25, 2024 13:37

title

cafa9d6

rsv full name

fb7c54d

nmdefries dismissed their stale review via fb7c54d June 25, 2024 17:39

Merge branch 'dev' into nsspDocs

585fbc3

nmdefries approved these changes Jun 25, 2024

View reviewed changes

nmdefries merged commit f8f760f into dev Jun 25, 2024
7 checks passed

nmdefries deleted the nsspDocs branch June 25, 2024 17:48

melange396 mentioned this pull request Jul 9, 2024

Release Delphi Epidata 4.1.24 #1489

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

nssp documentation draft #1439

nssp documentation draft #1439

dsweber2 commented May 17, 2024 •

edited by nmdefries

Loading

nmdefries left a comment

nmdefries Jun 6, 2024

dsweber2 Jun 6, 2024

nmdefries Jun 6, 2024

nmdefries commented Jun 6, 2024

nmdefries Jun 6, 2024

dsweber2 Jun 6, 2024

nmdefries Jun 6, 2024

tinatownes Jun 7, 2024

dsweber2 Jun 7, 2024

nmdefries Jun 7, 2024

tinatownes Jun 8, 2024

nmdefries Jun 6, 2024

dsweber2 Jun 6, 2024

minhkhul left a comment

nmdefries left a comment

nmdefries left a comment

sonarcloud bot commented Jun 25, 2024

		This data source has frequent backfill, primarily arising from newly included EDs. When a new facility joins the reporting network, its historical data is added to the dataset, resulting in changes to historical values for every geographic level that ED is part of (county through nation). Because of this, the broadest geographic levels are more likely to be revised.

		In previous revisions, we have noted changes to values dating back about 2 years.

	## Table of Contents
	{: .no_toc .text-delta}

	1. TOC
	{:toc}

	## Estimation


		## Missingness

		As of May 2024, NSSP received data from 78% of US EDs.

nssp documentation draft #1439

nssp documentation draft #1439

Conversation

dsweber2 commented May 17, 2024 • edited by nmdefries Loading

Summary:

Prerequisites:

nmdefries left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nmdefries commented Jun 6, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

minhkhul left a comment

Choose a reason for hiding this comment

nmdefries left a comment

Choose a reason for hiding this comment

nmdefries left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Jun 25, 2024

Quality Gate passed

dsweber2 commented May 17, 2024 •

edited by nmdefries

Loading