Bustub doesn't support OR statement now.

[El-even-11]

In src/binder/bind_select.cpp, AND/OR are both treated as AND.
Is this a bug or feature?
Related pr #408

[skyzh]

Line number?

[El-even-11]

Line 745 in function BindBoolExpr.

switch (root->boolop) {
    case duckdb_libpgquery::PG_AND_EXPR:
    case duckdb_libpgquery::PG_OR_EXPR: {  // and & or 
      std::string op_name;
      if (root->boolop == duckdb_libpgquery::PG_AND_EXPR) {
        op_name = "and";
      } else if (root->boolop == duckdb_libpgquery::PG_OR_EXPR) {
        op_name = "or";
      } else {
        UNREACHABLE("invalid op");
      }

      auto exprs = BindExpressionList(root->args);
      if (exprs.size() <= 1) {
        throw bustub::Exception("AND should have at least 1 arg");
      }
      auto expr = std::make_unique<BoundBinaryOp>("and", std::move(exprs[0]), std::move(exprs[1]));   
      for (size_t i = 2; i < exprs.size(); i++) {
        expr = std::make_unique<BoundBinaryOp>("and", std::move(expr), std::move(exprs[i]));   // only and
      }
      return expr;
    }
    case duckdb_libpgquery::PG_NOT_EXPR: {
        ...
    }
  }

[El-even-11]

It seems that "and" at line 763 & 765 should be replaced with op_name?

auto expr = std::make_unique<BoundBinaryOp>("and", std::move(exprs[0]), std::move(exprs[1]));  // here
      for (size_t i = 2; i < exprs.size(); i++) {
        expr = std::make_unique<BoundBinaryOp>("and", std::move(expr), std::move(exprs[i]));  // here
      }

[skyzh]

You're correct! Would you please help send a PR to fix this?

[El-even-11]

#485

[El-even-11]

I'm not sure whether this is the right place where OR is broken, but OR truly performs incorrectly in bustub webshell.