Skip to content

Add oracle to the set of produced benchbase docker images #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/maven.yml
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,7 @@ jobs:
runs-on: ubuntu-latest
env:
DOCKER_BUILDKIT: 1
BENCHBASE_PROFILES: 'cockroachdb mariadb mysql postgres spanner phoenix sqlserver sqlite'
BENCHBASE_PROFILES: 'cockroachdb mariadb mysql oracle phoenix postgres spanner sqlite sqlserver'
CONTAINER_REGISTRY_NAME: ${{ secrets.ACR_LOGINURL }}
services:
postgres: # https://hub.docker.com/_/postgres
Expand Down
2 changes: 1 addition & 1 deletion docker/benchbase/common-env.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Try to read some values from the environment or else set some defaults.
# The profiles to build:
export BENCHBASE_PROFILES="${BENCHBASE_PROFILES:-cockroachdb mariadb mysql postgres spanner phoenix sqlserver sqlite}"
export BENCHBASE_PROFILES="${BENCHBASE_PROFILES:-cockroachdb mariadb mysql oracle phoenix postgres spanner sqlite sqlserver}"
# The profile to run:
export BENCHBASE_PROFILE="${BENCHBASE_PROFILE:-postgres}"
# Whether to clean the build before/after/both/never:
Expand Down
2 changes: 1 addition & 1 deletion docker/benchbase/devcontainer/build-in-container.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
# Make sure any failure halts the rest of the operation.
set -eu -o pipefail

BENCHBASE_PROFILES="${BENCHBASE_PROFILES:-cockroachdb mariadb mysql postgres spanner phoenix sqlserver sqlite}"
BENCHBASE_PROFILES="${BENCHBASE_PROFILES:-cockroachdb mariadb mysql oracle phoenix postgres spanner sqlite sqlserver}"
CLEAN_BUILD="${CLEAN_BUILD:-true}" # true, false, pre, post
SKIP_TESTS="${SKIP_TESTS:-false}"

Expand Down