Skip to content

Commit c945629

Browse files
HyukjinKwoncmonkey
authored andcommitted
[SPARK-17213][SQL][FOLLOWUP] Re-enable Parquet filter tests for binary and string
## What changes were proposed in this pull request? This PR proposes to enable the tests for Parquet filter pushdown with binary and string. This was disabled in apache#16106 due to Parquet's issue but it is now revived in apache#16791 after upgrading Parquet to 1.8.2. ## How was this patch tested? Manually tested `ParquetFilterSuite` via IDE. Author: hyukjinkwon <gurwls223@gmail.com> Closes apache#16817 from HyukjinKwon/SPARK-17213.
1 parent f6d763b commit c945629

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -229,8 +229,7 @@ class ParquetFilterSuite extends QueryTest with ParquetTest with SharedSQLContex
229229
}
230230
}
231231

232-
// See SPARK-17213: https://issues.apache.org/jira/browse/SPARK-17213
233-
ignore("filter pushdown - string") {
232+
test("filter pushdown - string") {
234233
withParquetDataFrame((1 to 4).map(i => Tuple1(i.toString))) { implicit df =>
235234
checkFilterPredicate('_1.isNull, classOf[Eq[_]], Seq.empty[Row])
236235
checkFilterPredicate(
@@ -258,8 +257,7 @@ class ParquetFilterSuite extends QueryTest with ParquetTest with SharedSQLContex
258257
}
259258
}
260259

261-
// See SPARK-17213: https://issues.apache.org/jira/browse/SPARK-17213
262-
ignore("filter pushdown - binary") {
260+
test("filter pushdown - binary") {
263261
implicit class IntToBinary(int: Int) {
264262
def b: Array[Byte] = int.toString.getBytes(StandardCharsets.UTF_8)
265263
}

0 commit comments

Comments
 (0)